bugyaGTD - Yet Another Getting Things Done. - Bugs: bug #13309, fix crash when feeding commands...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #13309: fix crash when feeding commands bad arguments

Submitted by:  Ward Vandewege <ward>
Submitted on:  Fri 03 Apr 2009 02:40:42 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Privacy: PublicAssigned to: MiKaël NAVARRO <klnavarro>
Open/Closed: Closed

Wed 15 Apr 2009 12:54:41 PM UTC, comment #5:

No problem, sorry for the Changelog "not precise enough".

MiKaël NAVARRO <klnavarro>
Project AdministratorIn charge of this item.
Wed 15 Apr 2009 12:42:49 PM UTC, comment #4:

Yes, you are right. It seems there were more changes from 0.2.4 to 0.2.5 than what the changelog suggests. So please close this ticket, it's not an issue anymore with 0.2.5.

Ward Vandewege <ward>
Wed 15 Apr 2009 06:49:48 AM UTC, comment #3:

Hi, when looking on your patch files (yagtd-fix-crashes2.patch vs/ yagtd-fix-crashed.patch) I notice no differences? And your patch is already applied on version 0.2.5!
So, when I test with yagtd (v0.2.5) I can't reproduce your case?

mickey@bunny:~/dev/python/gtd/yagtd-0.2.5$ python src/yagtd.py -c tests/todo.txt
11 tasks loaded from 'tests/todo.txt'
[...]
GTD> ls
1:(4.010401) Etudier GTD. @home p:GTD !Next U:3 I:5 T:40H S:2006-10-30
2:(4.074310) Appliquer la methode GTD. @everywhere U:4 I:5 T:30M R:168H S:2006-12-16
7:(3.162278) Ameliorer Rhinote (et contacter l'auteur). @home @computer p:GTD U:3 I:4 C:40 T:24H S:2006-11-12
8:(3.193744) Scrawl-it (becquet = 12.7x7.7, 7.5x7.5; gtk, wxwin). @computer p:GTD U:3 I:4 C:40 T:1H S:2006-11-12
9:(2.323790) Etudier le Mind-mapping. @home p:MindMapping U:2 I:3 T:1H S:2006-11-06
11:(2.720294) LM revue de presse. @home @computer p:Doc U:1 I:3 T:1H R:720H S:2007-06-01 D:2007-07-01

GTD> complete 49 90%
nothing done?

GTD> complete 1 60%
nothing done?

GTD> complete 1 90
Task #1 modified

Could you precise your case? And give me an example of todo.txt?
Thanks in advance for your help.

MiKaël NAVARRO <klnavarro>
Project AdministratorIn charge of this item.
Tue 14 Apr 2009 11:42:29 PM UTC, comment #2:

Please - if you look carefully you'll see it's a different problem. Just read the bug report. This bug and the patch fixes issues when you feed invalid arguments to commands. Bug 12793 (https://gna.org/bugs/?12793) was about missing arguments.

Ward Vandewege <ward>
Tue 14 Apr 2009 08:21:22 PM UTC, comment #1:

Seems to be a duplicate of bug #12793..?

MiKaël NAVARRO <klnavarro>
Project AdministratorIn charge of this item.
Fri 03 Apr 2009 02:40:42 AM UTC, original submission:

when feeding the 'complete' command arguments like this, it crashes yagtd:

GTD> complete 49 90%
Traceback (most recent call last):
File "/personal/projects/yagtd/yagtd.py.0.2.5", line 975, in <module>
main(options)
File "/personal/projects/yagtd/yagtd.py.0.2.5", line 936, in main
gtd_cmd.cmdloop()
File "/usr/lib/python2.5/cmd.py", line 142, in cmdloop
stop = self.onecmd(line)
File "/usr/lib/python2.5/cmd.py", line 219, in onecmd
return func(arg)
File "/personal/projects/yagtd/yagtd.py.0.2.5", line 597, in do_complete
if idx and re.match(NUMBER_MATCH, percent):
File "/usr/lib/python2.5/re.py", line 137, in match
return _compile(pattern, flags).match(string)
TypeError: expected string or buffer

The attached patch fixes that for all commands that suffer from it.

Ward Vandewege <ward>

 

Attached Files
file #5560:  yagtd-fix-crashes2.patch added by ward (3kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by klnavarro (Updated the item)
  • -unavailable- added by ward (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 15 Apr 2009 12:54:41 PM UTCklnavarroStatusNeed Info=>Fixed
      Open/ClosedOpen=>Closed
    Wed 15 Apr 2009 06:49:48 AM UTCklnavarroStatusDuplicate=>Need Info
      Open/ClosedClosed=>Open
    Tue 14 Apr 2009 08:23:59 PM UTCklnavarroOpen/ClosedOpen=>Closed
    Tue 14 Apr 2009 08:21:22 PM UTCklnavarroStatusConfirmed=>Duplicate
    Wed 08 Apr 2009 08:31:50 PM UTCklnavarroStatusNone=>Confirmed
      Assigned toNone=>klnavarro
    Fri 03 Apr 2009 02:40:43 AM UTCwardAttached File-=>Added yagtd-fix-crashes2.patch, #5560
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup