bugpokersource - Bugs: bug #13776, PacketPokerPlayerInfo() needs...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #13776: PacketPokerPlayerInfo() needs locale value ? PokerService.getPlayerInfo() refers to it

Submitted by:  Bradley M. Kuhn <bkuhn>
Submitted on:  Wed 24 Jun 2009 05:42:28 PM UTC  
 
Category: poker-networkSeverity: 2 - Minor
Priority: 5 - NormalStatus: Need Info
Privacy: PublicAssigned to: None
Open/Closed: Open

Tue 23 Feb 2010 06:09:45 PM UTC, comment #4:

Does this still happen with latest version fo poker-network 1.7.7 or 2.0 ?

Johan Euphrosine <proppy>
Project Member
Wed 24 Jun 2009 05:42:28 PM UTC, comment #3:

This item has been reassigned from the project pokersource support tracker to your tracker.

The original report is still available at support #2262

Following are the information included in the original report:

[field #0] Item ID: 2262
[field #1] Group ID: 1588
[field #2] Open/Closed: Open
[field #3] Severity: 2 - Minor
[field #4] Privacy: Public
[field #9] Category: poker-network
[field #10] Submitted by: bkuhn
[field #11] Assigned to: None
[field #12] Submitted on: Wednesday 02/11/2009 at 22:51
[field #13] Summary: PacketPokerPlayerInfo() needs locale value ? PokerService.getPlayerInfo() refers to it
[field #14] Original Submission: I just noticed that when I made the locale changes, I added a locale = setting in PokerService.getPlayerInfo() creation of the dummy info packet.

It s not clear to me that this was needed at all, and I don t think anything relies on it, but I ve left it in just in case there was a reason.

At some point, someone should investigate why this is done here, and if it was just an error or not. I was in the middle of doing some test coverage when I discovered it, so I just created this ticket and marked the places in the code that are relevant with FIXME_PokerPlayerInfoLocale
[field #16] Item Group: None
[field #17] Status: Confirmed
[field #18] Component Version: None
[field #19] Operating System: GNU/Linux
[field #20] Reproducibility: None
[field #21] Size (loc): None
[field #22] Fixed Release: None
[field #23] Planned Release: None
[field #24] Effort: 0.00
[field #28] Priority: 5 - Normal
[field #31] Percent Complete: 0%
[field #33] Release: None
[field #58] Custom Select Box #1: None
[field #59] Custom Select Box #2: None
[field #60] Custom Select Box #3: None
[field #61] Custom Select Box #4: None
[field #62] Custom Select Box #5: None
[field #63] Custom Select Box #6: None
[field #64] Custom Select Box #7: None
[field #65] Custom Select Box #8: None
[field #66] Custom Select Box #9: None
[field #67] Custom Select Box #10: None

Bradley M. Kuhn <bkuhn>
Project Administrator
Sat 04 Apr 2009 03:51:52 PM UTC, SVN revision :

Merged coverage-poker-network branch into trunk for 100% pokerservice.py coverage:
* Wrote numerous tests in test-pokerservice.py.in
* raise NotImplementedError() in getArguments() and maps2result() in
PokerXML. Closes sr #2274
* Created test-pokerservice-load.py.in, which meta-tests various loading
conditions of pokerservice.py
* Comments to note failed insert should return None in
PokerService.createTable(). See sr #2273
* Made notes about PokerPlayerInfoLocale in pokerservice.py and
pokerpackets.py, see sr #2262
* run.in now has pokerservice.py listed for 100% coverage!
* test-pokerservice-load.py.in and test-pokerservice-load.py call each
other via compile-command variable.
* Added test-pokerservice-load.py.in to configure.ac
* Minor fix to a comment in test-pokeravatar.py.in
* Detailed ChangeLog entries for what was done.

(Browse SVN revision )

Bradley M. Kuhn <bkuhn>
Project Administrator
Wed 11 Feb 2009 10:58:14 PM UTC, SVN revision :

Wrote test to cover default caes of PokerService.getPlayerInfo().
Discovered an odd thing while doing that: locale argument is given to
PacketPokerPlayerInfo() but is actually ignored. Note sure why that is
there, so I opened sr #2262 and made FIXME notes in the code.

(Browse SVN revision )

Bradley M. Kuhn <bkuhn>
Project Administrator
Wed 24 Jun 2009 05:42:28 PM UTC, original submission:

I just noticed that when I made the locale changes, I added a locale = setting in PokerService.getPlayerInfo() creation of the dummy info packet.

It's not clear to me that this was needed at all, and I don't think anything relies on it, but I've left it in just in case there was a reason.

At some point, someone should investigate why this is done here, and if it was just an error or not. I was in the middle of doing some test coverage when I discovered it, so I just created this ticket and marked the places in the code that are relevant with FIXME_PokerPlayerInfoLocale

Bradley M. Kuhn <bkuhn>
Project Administrator

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by proppy (Updated the item)
  • -unavailable- added by bkuhn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 23 Feb 2010 06:09:45 PM UTCproppyStatusNone=>Need Info
    Tue 23 Feb 2010 06:09:19 PM UTCproppyCategoryNone=>poker-network
    Wed 24 Jun 2009 05:42:28 PM UTCbkuhnReassign itempokersource, sr #2262=>pokersource, bug #13776
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup