bugpokersource - Bugs: bug #13777, PokerService.createTable() should...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #13777: PokerService.createTable() should fail if insert fails

Submitted by:  Bradley M. Kuhn <bkuhn>
Submitted on:  Wed 24 Jun 2009 05:42:50 PM UTC  
 
Category: poker-networkSeverity: 3 - Normal
Priority: 5 - NormalStatus: Confirmed
Privacy: PublicAssigned to: None
Open/Closed: Open

Tue 23 Feb 2010 05:50:06 PM UTC, comment #4:

The following comment is still in the code:
if cursor.rowcount != 1:
self.error("inserted %d rows (expected 1): %s " % ( cursor.rowcount, sql ))
# FIXME: sr #2273 notes that this should return None from right here if rowcount == 0

Johan Euphrosine <proppy>
Project Member
Wed 24 Jun 2009 05:42:50 PM UTC, comment #3:

This item has been reassigned from the project pokersource support tracker to your tracker.

The original report is still available at support #2273

Following are the information included in the original report:

[field #0] Item ID: 2273
[field #1] Group ID: 1588
[field #2] Open/Closed: Open
[field #3] Severity: 3 - Normal
[field #4] Privacy: Public
[field #9] Category: poker-network
[field #10] Submitted by: bkuhn
[field #11] Assigned to: None
[field #12] Submitted on: Monday 02/16/2009 at 23:33
[field #13] Summary: PokerService.createTable() should fail if insert fails
[field #14] Original Submission: Currently, the createTable() method in PokerService (found in pokerservice.py) continues on when the INSERT returns 0 rows. It probably should not do this; it should fail in some way, assuming that the table has not been created.

[field #16] Item Group: None
[field #17] Status: None
[field #18] Component Version: None
[field #19] Operating System: None
[field #20] Reproducibility: None
[field #21] Size (loc): None
[field #22] Fixed Release: None
[field #23] Planned Release: None
[field #24] Effort: 0.00
[field #28] Priority: 5 - Normal
[field #31] Percent Complete: 0%
[field #33] Release: None
[field #58] Custom Select Box #1: None
[field #59] Custom Select Box #2: None
[field #60] Custom Select Box #3: None
[field #61] Custom Select Box #4: None
[field #62] Custom Select Box #5: None
[field #63] Custom Select Box #6: None
[field #64] Custom Select Box #7: None
[field #65] Custom Select Box #8: None
[field #66] Custom Select Box #9: None
[field #67] Custom Select Box #10: None

Bradley M. Kuhn <bkuhn>
Project Administrator
Sat 04 Apr 2009 03:51:52 PM UTC, SVN revision :

Merged coverage-poker-network branch into trunk for 100% pokerservice.py coverage:
* Wrote numerous tests in test-pokerservice.py.in
* raise NotImplementedError() in getArguments() and maps2result() in
PokerXML. Closes sr #2274
* Created test-pokerservice-load.py.in, which meta-tests various loading
conditions of pokerservice.py
* Comments to note failed insert should return None in
PokerService.createTable(). See sr #2273
* Made notes about PokerPlayerInfoLocale in pokerservice.py and
pokerpackets.py, see sr #2262
* run.in now has pokerservice.py listed for 100% coverage!
* test-pokerservice-load.py.in and test-pokerservice-load.py call each
other via compile-command variable.
* Added test-pokerservice-load.py.in to configure.ac
* Minor fix to a comment in test-pokeravatar.py.in
* Detailed ChangeLog entries for what was done.

(Browse SVN revision )

Bradley M. Kuhn <bkuhn>
Project Administrator
Mon 16 Feb 2009 11:42:36 PM UTC, SVN revision :

Added a commented-out test that should succeed if sr # 2273 be deemed
valid and closed. Added comments in the test files and source to indicate
existence of sr #2273.

(Browse SVN revision )

Bradley M. Kuhn <bkuhn>
Project Administrator
Wed 24 Jun 2009 05:42:50 PM UTC, original submission:

Currently, the createTable() method in PokerService (found in pokerservice.py) continues on when the INSERT returns 0 rows. It probably should not do this; it should fail in some way, assuming that the table has not been created.

Bradley M. Kuhn <bkuhn>
Project Administrator

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by proppy (Posted a comment)
  • -unavailable- added by bkuhn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 23 Feb 2010 05:50:16 PM UTCproppyCategoryNone=>poker-network
    Tue 23 Feb 2010 05:50:06 PM UTCproppyStatusNone=>Confirmed
    Wed 24 Jun 2009 05:42:50 PM UTCbkuhnReassign itempokersource, sr #2273=>pokersource, bug #13777
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup