bugpokersource - Bugs: bug #13789, TablePicker() should return most...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #13789: TablePicker() should return most full table with a seat that matches given criteria()

Submitted by:  Bradley M. Kuhn <bkuhn>
Submitted on:  Thu 25 Jun 2009 01:44:21 PM UTC  
 
Category: NoneSeverity: 4 - Important
Priority: 5 - NormalStatus: Ready For Test
Privacy: PublicAssigned to: Bradley M. Kuhn <bkuhn>
Open/Closed: Closed

Sun 28 Jun 2009 11:30:20 PM UTC, SVN revision 5982:

Merged table-picker-bug-13789 into trunk. TablePicker() now returns
fullest table w/ seat that matches given criteria, which closed bug #13789.

This was implemented by simply adding an ORDER BY on listTables() query to
force the tables with the most players to be seen first by the selection
function, getTableBestByCriteria() which already returns when it finds the
first table that isn't full and the player has enough money to buy in for.

Loic raised concern about doing an ORDER BY serial as well, since it slows
the query down a bit. I left it in as it allows the semantic to be
clearly defined when there are ties.

(Browse SVN revision 5982)

Bradley M. Kuhn <bkuhn>
Project AdministratorIn charge of this item.
Sun 28 Jun 2009 09:15:58 PM UTC, SVN revision 5978:

On bug #13789, wrote to two tests that should succeed once this bug is
closed but currently fail.

(Browse SVN revision 5978)

Bradley M. Kuhn <bkuhn>
Project AdministratorIn charge of this item.
Sun 28 Jun 2009 08:23:44 PM UTC, SVN revision 5977:

Created branch, table-picker-bug-13789: Branched from trunk to begin work on resolving bug #13789

(Browse SVN revision 5977)

Bradley M. Kuhn <bkuhn>
Project AdministratorIn charge of this item.
Thu 25 Jun 2009 01:44:21 PM UTC, comment #2:

This item has been reassigned from the project pokersource support tracker to your tracker.

The original report is still available at support #2369

Following are the information included in the original report:

[field #0] Item ID: 2369
[field #1] Group ID: 1588
[field #2] Open/Closed: Open
[field #3] Severity: 2 - Minor
[field #4] Privacy: Public
[field #9] Category: poker-network
[field #10] Submitted by: bkuhn
[field #11] Assigned to: bkuhn
[field #12] Submitted on: Wednesday 06/24/2009 at 15:36
[field #13] Summary: Should TablePicker() favor tables with players even when min_players == 0 or is unset?
[field #14] Original Submission: If the TablePicker() client sends no min_players or min_players == 0, should it favor a table with at least one active player, or should it try to fill up a table with no players on it?

Argument for this:

TablePicker() is generally used to find a table where play is active, so it should only give an empty table as a last result.

Argument against this:

If the client really wanted a table with a game going, why didn t it just set min_players == 1?!?! We should assume if the min_players == 0 or is unset, that the client is happy with any table that fits the other criteria, even if no one is currently playing.

bkuhn is against this, I believe that proppy is for it. I m assigning this ticket initially to loic because I want his input before we decide.
[field #16] Item Group: None
[field #17] Status: Confirmed
[field #18] Component Version: None
[field #19] Operating System: GNU/Linux
[field #20] Reproducibility: None
[field #21] Size (loc): None
[field #22] Fixed Release: None
[field #23] Planned Release: None
[field #24] Effort: 0.00
[field #28] Priority: 5 - Normal
[field #31] Percent Complete: 0%
[field #33] Release: None
[field #58] Custom Select Box #1: None
[field #59] Custom Select Box #2: None
[field #60] Custom Select Box #3: None
[field #61] Custom Select Box #4: None
[field #62] Custom Select Box #5: None
[field #63] Custom Select Box #6: None
[field #64] Custom Select Box #7: None
[field #65] Custom Select Box #8: None
[field #66] Custom Select Box #9: None
[field #67] Custom Select Box #10: None

Bradley M. Kuhn <bkuhn>
Project AdministratorIn charge of this item.
Thu 25 Jun 2009 01:44:21 PM UTC, comment #1:

Based on discussion on #pokersource, we have decided that the semantics of the TablePicker() should be return the "fullest table with at least min_players".

However, everyone sees the value in a more complete semantic that can do more things with the TablePicker(). I will open another bug ticket after this one is resoved to do that.

Bradley M. Kuhn <bkuhn>
Project AdministratorIn charge of this item.
Thu 25 Jun 2009 01:44:21 PM UTC, original submission:

If the TablePicker() client sends no min_players or min_players == 0, should it favor a table with at least one active player, or should it try to fill up a table with no players on it?

Argument for this:

TablePicker() is generally used to find a table where play is active, so it should only give an empty table as a last result.

Argument against this:

If the client really wanted a table with a game going, why didn't it just set min_players == 1?!?! We should assume if the min_players == 0 or is unset, that the client is happy with any table that fits the other criteria, even if no one is currently playing.

bkuhn is against this, I believe that proppy is for it. I'm assigning this ticket initially to loic because I want his input before we decide.

Bradley M. Kuhn <bkuhn>
Project AdministratorIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bkuhn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 28 Jun 2009 11:33:32 PM UTCbkuhnStatusConfirmed=>Ready For Test
      Open/ClosedOpen=>Closed
    Thu 25 Jun 2009 01:49:39 PM UTCbkuhnSummaryShould TablePicker() favor tables with players even when min_players == 0 or is unset?=>TablePicker() should return most full table with a seat that matches given criteria()
    Thu 25 Jun 2009 01:44:55 PM UTCbkuhnSeverity2 - Minor=>4 - Important
      StatusNone=>Confirmed
      Assigned toNone=>bkuhn
    Thu 25 Jun 2009 01:44:21 PM UTCbkuhnReassign itempokersource, sr #2369=>pokersource, bug #13789
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup