On bug #13789, wrote to two tests that should succeed once this bug is
closed but currently fail.

(Browse SVN revision 5978)

This item has been reassigned from the project pokersource support tracker to your tracker.

The original report is still available at support #2369

Following are the information included in the original report:

[field #0] Item ID: 2369
[field #1] Group ID: 1588
[field #2] Open/Closed: Open
[field #3] Severity: 2 - Minor
[field #4] Privacy: Public
[field #9] Category: poker-network
[field #10] Submitted by: bkuhn
[field #11] Assigned to: bkuhn
[field #12] Submitted on: Wednesday 06/24/2009 at 15:36
[field #13] Summary: Should TablePicker() favor tables with players even when min_players == 0 or is unset?
[field #14] Original Submission: If the TablePicker() client sends no min_players or min_players == 0, should it favor a table with at least one active player, or should it try to fill up a table with no players on it?

Argument for this:

TablePicker() is generally used to find a table where play is active, so it should only give an empty table as a last result.

Argument against this:

If the client really wanted a table with a game going, why didn t it just set min_players == 1?!?! We should assume if the min_players == 0 or is unset, that the client is happy with any table that fits the other criteria, even if no one is currently playing.

bkuhn is against this, I believe that proppy is for it. I m assigning this ticket initially to loic because I want his input before we decide.
[field #16] Item Group: None
[field #17] Status: Confirmed
[field #18] Component Version: None
[field #19] Operating System: GNU/Linux
[field #20] Reproducibility: None
[field #21] Size (loc): None
[field #22] Fixed Release: None
[field #23] Planned Release: None
[field #24] Effort: 0.00
[field #28] Priority: 5 - Normal
[field #31] Percent Complete: 0%
[field #33] Release: None
[field #58] Custom Select Box #1: None
[field #59] Custom Select Box #2: None
[field #60] Custom Select Box #3: None
[field #61] Custom Select Box #4: None
[field #62] Custom Select Box #5: None
[field #63] Custom Select Box #6: None
[field #64] Custom Select Box #7: None
[field #65] Custom Select Box #8: None
[field #66] Custom Select Box #9: None
[field #67] Custom Select Box #10: None

If the TablePicker() client sends no min_players or min_players == 0, should it favor a table with at least one active player, or should it try to fill up a table with no players on it?

Argument for this:

TablePicker() is generally used to find a table where play is active, so it should only give an empty table as a last result.

Argument against this:

If the client really wanted a table with a game going, why didn't it just set min_players == 1?!?! We should assume if the min_players == 0 or is unset, that the client is happy with any table that fits the other criteria, even if no one is currently playing.

bkuhn is against this, I believe that proppy is for it. I'm assigning this ticket initially to loic because I want his input before we decide.