bugpokersource - Bugs: bug #13854, PacketPokerTablePicker() will...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #13854: PacketPokerTablePicker() will possibly return a table the player has already joined/is seated at.

Submitted by:  Bradley M. Kuhn <bkuhn>
Submitted on:  Fri 03 Jul 2009 05:01:09 PM UTC  
 
Category: poker-networkSeverity: 2 - Minor
Priority: 1 - LaterStatus: Confirmed
Privacy: PublicAssigned to: None
Open/Closed: Open

Fri 03 Jul 2009 05:24:14 PM UTC, SVN revision 5994:

Toward bug #13854: pokeravatar no longer needs to convert to a query string
for PacketPokerTablePicker(). Lots fewer tests and still 100% coverage!

(Browse SVN revision 5994)

Bradley M. Kuhn <bkuhn>
Project Administrator
Fri 03 Jul 2009 05:12:56 PM UTC, SVN revision 5993:

Toward bug #13854: Changed getTableBestByCriteria() and its tests to expect
searchTables() call underneath. 100% test coverage to pokerservice.py
restored.

(Browse SVN revision 5993)

Bradley M. Kuhn <bkuhn>
Project Administrator
Fri 03 Jul 2009 05:01:09 PM UTC, original submission:

The PokerService. getTableBestByCriteria() method does not account for the fact that PokerService.searchTables() might return a table in its list where player represented by 'serial' is already sitting at.

This means that if a player is already playing at a table and reissues PacketPokerTablePicker() via his client, the player may get a table on which the player is already joined or seated at.

I do not believe the behavior of PacketPokerTablePicker() is defined properly in this scenario, and thus weird results may occur.

Likely, getTablebestByCriteria() should eliminate from consideration tables which player is already seated at. However, it probably should handle gracefully the case where the player is already joined (i.e., watching) the game.

Bradley M. Kuhn <bkuhn>
Project Administrator

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bkuhn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup