bugBattle for Wesnoth - Bugs: bug #13926, Scenario name (unicode) used for...

 
 
Show feedback again

bug #13926: Scenario name (unicode) used for generated save filenames, breaking autosave.

Submitted by:  Alexander van Gessel <ai0867>
Submitted on:  Fri 10 Jul 2009 04:59:41 AM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group:  None of the others
Status: FixedPrivacy: Public
Assigned to: Daniel <gfgtdf>Open/Closed: Closed
Release: 1.6.4Operating System: Win XP

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 10 Nov 2014 12:15:17 AM UTC, comment #7:

Fixed in version 1.11.19.

Ignacio R. Morelle <shadowmaster>
Project Administrator
Fri 08 Mar 2013 10:27:09 PM UTC, comment #6:

More general version is bug #20089.

Alexander van Gessel <ai0867>
Project Member
Sat 05 Nov 2011 04:44:04 PM UTC, comment #5:

Replacing the filesystem code now is too big a change in this part of the release cycle. I'll take a look at it once 1.10 is out.

Alexander van Gessel <ai0867>
Project Member
Sun 07 Feb 2010 03:51:02 PM UTC, comment #4:

The proper fix for this would be moving to boost::filesystem, which won't be done before 1.8.
Unless anyone has a quicker fix, this bug should be marked as postponed.

Alexander van Gessel <ai0867>
Project Member
Mon 04 Jan 2010 04:32:35 PM UTC, comment #3:

All strings in wesnoth should be in utf-8 while ofstream etc on windows expect filenames to be in native 8-bit encoding. That encoding depends on system settings. The savegame code recodes filenames to native encoding using winapi calls, but this conversion is lossy. E.g. you won't be able to save with japanese filenames if your native encoding is cp1251. The only satisfactory way of fixing that is to use unicode versions of winapi calls(CreateFileW, etc). This problem doesn't arise on POSIX platforms because most of them use utf-8 as their native encoding.

Sergey Popov <loonycyborg>
Project Member
Sat 11 Jul 2009 01:22:04 AM UTC, comment #2:

filesystem.cpp uses std::ofstream, which is not required to accept unicode.

Alexander van Gessel <ai0867>
Project Member
Fri 10 Jul 2009 06:26:52 AM UTC, comment #1:

I don't think it is that easy ("unicode characters which aren't allowed in filenames"). Indeed, another user reported that he was able to create and save filenames with multibyte characters in other applications, but that Wesnoth wasn't. See this other forum topic. So the issue is not really with unicode characters, but with the way Wesnoth handles filenames on Windows.

Guillaume Melquiond <silene>
Fri 10 Jul 2009 04:59:41 AM UTC, original submission:

The scenario name is used for automatically generated filenames for saves. The name (and its translations) can contain unicode characters which aren't allowed in filenames on some filesystems.

Forum topic

Alexander van Gessel <ai0867>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by loonycyborg (Posted a comment)
  • -unavailable- added by silene (Posted a comment)
  • -unavailable- added by ai0867 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 10 Nov 2014 12:15:17 AM UTCshadowmasterStatusNone=>Fixed
      Assigned toai0867=>gfgtdf
      Open/ClosedOpen=>Closed
    Sun 29 Jan 2012 09:36:11 PM UTCshadowmasterStatusPostponed=>None
    Sat 05 Nov 2011 04:44:04 PM UTCai0867StatusNone=>Postponed
      Assigned toNone=>ai0867
    Fri 10 Jul 2009 06:26:52 AM UTCsileneItem GroupNone=> None of the others
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup