bugFreeciv - Bugs: bug #14275, Crash when entering black square...

 
 
Show feedback again

bug #14275: Crash when entering black square (2.1.9)

Submitted by:  Ann <kudra>
Submitted on:  Wed 09 Sep 2009 08:26:33 PM UTC  
 
Category: client-gtk-2.0Severity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: pepeto <pepeto>Open/Closed: Closed
Release: Operating System: None
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 22 Oct 2009 12:55:47 PM UTC, comment #16:

You last attached pieces of informations confirm that this bug is rightly fixed. Thank you.

pepeto <pepeto>
Project MemberIn charge of this item.
Thu 22 Oct 2009 12:45:11 PM UTC, comment #15:

Also, here is a saved game one turn before vision was shared.

(file #7060)

Ann <kudra>
Thu 22 Oct 2009 12:40:50 PM UTC, comment #14:

I know there's been a fix for this bug already but I thought I'd add a few details just in case this isn't the same as the other bug.

I've attached a screenshot of the black square from a different game. In that game I am allied with the Spanish. If I removed shared vision, and cancel the treaty with them, then wait a turn until they remove vision from me, the black square remains and it still causes a crash when I enter the square. However, if I load the saved version of the game, the square is displayed normally.

Ann <kudra>
Sat 17 Oct 2009 11:40:54 AM UTC, SVN revision 16145:

Giving shared vision really reveal tiles and units which are in your city view
range but still unknown, causing crash on client side.

Reported by Ann (kudra)

See gna bug #14275

(Browse SVN revision 16145)

pepeto <pepeto>
Project MemberIn charge of this item.
Sat 17 Oct 2009 11:40:51 AM UTC, SVN revision 16144:

Giving shared vision really reveal tiles and units which are in your city view
range but still unknown, causing crash on client side.

Reported by Ann (kudra)

See gna bug #14275

(Browse SVN revision 16144)

pepeto <pepeto>
Project MemberIn charge of this item.
Sat 17 Oct 2009 11:40:46 AM UTC, SVN revision 16143:

Giving shared vision really reveal tiles and units which are in your city view
range but still unknown, causing crash on client side.

Reported by Ann (kudra)

See gna bug #14275

(Browse SVN revision 16143)

pepeto <pepeto>
Project MemberIn charge of this item.
Fri 16 Oct 2009 10:03:30 PM UTC, comment #10:

> But if you've found some way to reproduce it that's good, as I
> was unable to get it to happen except by chance.


Actually I had to revert the patch for bug #14275 to get black squares. But in the current version, units are not reveled, and there view neither if are in your city view range.

pepeto <pepeto>
Project MemberIn charge of this item.
Fri 16 Oct 2009 11:00:25 AM UTC, comment #9:

In my game when I returned to the game saved immediately before the crash, the black square was no longer black. But if you've found some way to reproduce it that's good, as I was unable to get it to happen except by chance.

Ann <kudra>
Thu 15 Oct 2009 11:26:16 AM UTC, comment #8:

Got it. Savegame attached. Steps to reproduce: Argentine gives shared vision.

It occurs mainly in S2_1. But the behaviour could occurs when the game is edited in S2_2 and trunk.

(file #6996, file #6997)

pepeto <pepeto>
Project MemberIn charge of this item.
Thu 15 Oct 2009 10:03:24 AM UTC, comment #7:

I see what could have caused that bug. I think that there was an allied unit seeing that tile when you shared vision. Cities squares are always marked as seen. So the count passed from 1 to 2 whereas it needs to pass from 0 to x to have the tile info sent.

Do you have a former savegame (some turns before), just before you shared vision with your allied?

pepeto <pepeto>
Project MemberIn charge of this item.
Thu 15 Oct 2009 08:18:39 AM UTC, comment #6:

I did not disable fog of war in my game; both times that I witnessed it I was using default settings.

One thing that I had in common in both my instances was that I was allied with an AI player.

Ann <kudra>
Sun 11 Oct 2009 09:56:59 PM UTC, SVN revision 16099:

Sharing vision when the fog of war is disabled don't let black square over
vision giver units.

Reported by Jere Toivanen and probably Ann (kudra)

See gna bug #14275

(Browse SVN revision 16099)

pepeto <pepeto>
Project MemberIn charge of this item.
Sun 11 Oct 2009 09:56:54 PM UTC, SVN revision 16098:

Sharing vision when the fog of war is disabled don't let black square over
vision giver units.

Reported by Jere Toivanen and probably Ann (kudra)

See gna bug #14275

(Browse SVN revision 16098)

pepeto <pepeto>
Project MemberIn charge of this item.
Sun 11 Oct 2009 09:56:50 PM UTC, SVN revision 16097:

Sharing vision when the fog of war is disabled don't let black square over
vision giver units.

Reported by Jere Toivanen and probably Ann (kudra)

See gna bug #14275

(Browse SVN revision 16097)

pepeto <pepeto>
Project MemberIn charge of this item.
Sat 10 Oct 2009 12:33:54 PM UTC, comment #2:

Did you play this game with the fog of war disabled?

pepeto <pepeto>
Project MemberIn charge of this item.
Sat 10 Oct 2009 09:27:57 AM UTC, comment #1:

See also bug #14489

pepeto <pepeto>
Project MemberIn charge of this item.
Wed 09 Sep 2009 08:26:33 PM UTC, original submission:

A ship encountered a square which stayed black even though the ship was right next to it and should have been able to see the square. When I made the ship enter the square, civclient crashed. I am attaching the crash report.

When I reloaded the game which had been saved right before the crash, the black square (off the coast from Thugga, directly to the right of the caravel) was no longer black, but instead a standard ocean square. I am attaching the saved game, although I don't think this will demonstrate the bug--it looks more like a GUI issue. This is the second time I have observed this particular issue. Unfortunately it is rather difficult to replicate.

Linux 2.6.29.6-217.2.16.fc11.i586 #1 SMP Mon Aug 24 17:01:46 EDT 2009 i686 i686 i386 GNU/Linux
Freeciv version 2.1.9 gui-gtk-2.0

Ann <kudra>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #7060:  civgame+0400.sav.gz added by kudra (55kB - application/x-gzip - Saved game 1 turn before shared vision)
file #7059:  small_black_square.png added by kudra (169kB - image/png - Screenshot of black square)
file #6996:  shared_vision.sav.gz added by pepeto (23kB - application/x-gzip)
file #6628:  fog_bug.sav.gz added by kudra (96kB - application/x-gzip)
file #6627:  civclient-bugreport.txt added by kudra (369kB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pepeto (Posted a comment)
  • -unavailable- added by kudra (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 22 Oct 2009 12:45:11 PM UTCkudraAttached File-=>Added civgame+0400.sav.gz, #7060
    Thu 22 Oct 2009 12:36:09 PM UTCkudraAttached File-=>Added small_black_square.png, #7059
    Sat 17 Oct 2009 11:41:24 AM UTCpepetoStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Thu 15 Oct 2009 11:26:16 AM UTCpepetoAttached File-=>Added shared_vision.sav.gz, #6996
      Attached File-=>Added trunk_S2_2_S2_1_shared_vision.diff, #6997
      StatusNone=>Ready For Test
      Planned ReleaseNone=>2.1.10
    Thu 15 Oct 2009 10:03:42 AM UTCpepetoAssigned toNone=>pepeto
    Wed 09 Sep 2009 08:26:34 PM UTCkudraAttached File-=>Added fog_bug.sav.gz, #6628
    Wed 09 Sep 2009 08:26:33 PM UTCkudraAttached File-=>Added civclient-bugreport.txt, #6627
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup