(
Jump to the original submission)
Thu 29 Oct 2009 09:17:28 PM UTC, comment #6:
Should be fixed with:
http://svn.gna.org/viewcvs/pokersource?rev=6313&view=rev
|
Thu 29 Oct 2009 04:07:47 PM UTC, comment #5:
After applying the patch, no more PokerRestClient spam in logs:
proppy@pasokon:~/Desktop/jpoker$ tail -f /var/log/poker-network-proxy.log
2009-10-29 17:00:42+0100 [-] PokerResource: (x-forwarded-for:::1) render {"type":"PacketPokerLongPoll"} returns []
2009-10-29 17:00:42+0100 [-] PokerAvatar: connection lost for proppy/4
2009-10-29 17:00:42+0100 [-] PokerAvatarCollection:service:remove 4 PokerAvatar serial = 4, name = proppy
2009-10-29 17:00:45+0100 [-] PokerAvatar: longPollDeferredTimeout([]):
2009-10-29 17:00:45+0100 [-] PokerResource: (x-forwarded-for:::1) render {"type":"PacketPokerLongPoll"} returns []
2009-10-29 17:00:45+0100 [-] PokerAvatar: connection lost for proppy2/5
2009-10-29 17:00:45+0100 [-] PokerAvatarCollection:service:remove 5 PokerAvatar serial = 5, name = proppy2
2009-10-29 17:01:18+0100 [-] PokerService: checkTourneysSchedule
2009-10-29 17:01:18+0100 [-] PokerService: cancelTimer checkTourney
2009-10-29 17:01:18+0100 [-] PokerService: cancelTimer messages
2009-10-29 17:02:18+0100 [-] PokerService: checkTourneysSchedule
2009-10-29 17:02:18+0100 [-] PokerService: cancelTimer checkTourney
2009-10-29 17:02:18+0100 [-] PokerService: cancelTimer messages
2009-10-29 17:03:18+0100 [-] PokerService: checkTourneysSchedule
2009-10-29 17:03:18+0100 [-] PokerService: cancelTimer checkTourney
2009-10-29 17:03:18+0100 [-] PokerService: cancelTimer messages
|
Thu 29 Oct 2009 03:11:30 PM UTC, comment #4:
Here is a tentative patch to fix this issue.
(file #7164)
|
Thu 29 Oct 2009 09:59:30 AM UTC, comment #3:
- call clearTimeout when removing PokerRestClient instance from game_id2rest_client dict.
|
Wed 28 Oct 2009 10:14:38 PM UTC, comment #2:
Implementation guidelines:
- set longPollFrequency = -1, to control long poll manually in test cases
- use scheduleLongPoll instead of longPoll after constructing PokerRestClient to prevent initial sendPacket(PacketPokerLongPoll) sendPacket(PacketPokerLongPollReturn)
- don't scheduleLongPoll/longPollCallback for PokerRestClient with resthost and without game_id (tourney)
|
Tue 27 Oct 2009 05:34:47 PM UTC, comment #1:
Hi,
I attached a test case showing that pokerrestclient looping long poll prevent deletion.
(file #7139)
|
Fri 23 Oct 2009 05:48:23 PM UTC, original submission:
Hi,
I noticed that with a server and a proxy, and a client has connected and leaved.
PokerRestClient instances keeps long polling, I believe this maybe due to clearTimeout not being called when deleting PokerRestClient instance from game_id2rest_client.
2009-10-23 19:47:12+0200 [HTTPPageGetter,client] PokerRestClient(localhost:19384) receivePacket []
2009-10-23 19:47:12+0200 [HTTPPageGetter,client] PokerAvatar: incomingDistributedPackets([], 881)
2009-10-23 19:47:12+0200 [HTTPPageGetter,client] Stopping factory <RestClientFactory: http://localhost:19384/POKER_REST?explain=no&uid=F722112DA4BE2DFC9E3D41A2FF4665BC82CF7769&auth=1741D49AB177B93912D330FE601E8B558306986A>
2009-10-23 19:47:12+0200 [HTTPPageGetter,client] PokerRestClient(localhost:19384) receivePacket []
2009-10-23 19:47:12+0200 [HTTPPageGetter,client] PokerAvatar: incomingDistributedPackets([], 881)
2009-10-23 19:47:12+0200 [HTTPPageGetter,client] Stopping factory <RestClientFactory: http://localhost:19384/POKER_REST?explain=no&uid=F722112DA4BE2DFC9E3D41A2FF4665BC82CF7769&auth=1741D49AB177B93912D330FE601E8B558306986A>
2009-10-23 19:47:12+0200 [-] PokerRestClient(localhost:19384) sendPacket { "type": "PacketPokerLongPoll" }
2009-10-23 19:47:12+0200 [-] Starting factory <RestClientFactory: http://localhost:19384/POKER_REST?explain=no&uid=F722112DA4BE2DFC9E3D41A2FF4665BC82CF7769&auth=1741D49AB177B93912D330FE601E8B558306986A>
2009-10-23 19:47:12+0200 [-] PokerRestClient(localhost:19384) sendPacket { "type": "PacketPokerLongPoll" }
2009-10-23 19:47:12+0200 [-] Starting factory <RestClientFactory: http://localhost:19384/POKER_REST?explain=no&uid=F722112DA4BE2DFC9E3D41A2FF4665BC82CF7769&auth=1741D49AB177B93912D330FE601E8B558306986A>
2009-10-23 19:47:20+0200 [HTTPPageGetter,client] PokerRestClient(localhost:19384) receivePacket []
2009-10-23 19:47:20+0200 [HTTPPageGetter,client] PokerAvatar: incomingDistributedPackets([], 881)
2009-10-23 19:47:20+0200 [HTTPPageGetter,client] Stopping factory <RestClientFactory: http://localhost:19384/POKER_REST?explain=no&uid=F722112DA4BE2DFC9E3D41A2FF4665BC82CF7769&auth=1741D49AB177B93912D330FE601E8B558306986A>
2009-10-23 19:47:21+0200 [-] PokerRestClient(localhost:19384) sendPacket { "type": "PacketPokerLongPoll" }
2009-10-23 19:47:21+0200 [-] Starting factory <RestClientFactory: http://localhost:19384/POKER_REST?explain=no&uid=F722112DA4BE2DFC9E3D41A2FF4665BC82CF7769&auth=1741D49AB177B93912D330FE601E8B558306986A>
2009-10-23 19:47:21+0200 [HTTPPageGetter,client] PokerRestClient(localhost:19384) receivePacket []
2009-10-23 19:47:21+0200 [HTTPPageGetter,client] PokerAvatar: incomingDistributedPackets([], 881)
2009-10-23 19:47:21+0200 [HTTPPageGetter,client] Stopping factory <RestClientFactory: http://localhost:19384/POKER_REST?explain=no&uid=F722112DA4BE2DFC9E3D41A2FF4665BC82CF7769&auth=1741D49AB177B93912D330FE601E8B558306986A>
2009-10-23 19:47:21+0200 [-] PokerRestClient(localhost:19384) sendPacket { "type": "PacketPokerLongPoll" }
2009-10-23 19:47:21+0200 [-] Starting factory <RestClientFactory: http://localhost:19384/POKER_REST?explain=no&uid=F722112DA4BE2DFC9E3D41A2FF4665BC82CF7769&auth=1741D49AB177B93912D330FE601E8B558306986A>
|
Depends on the following items: None found
Items that depend on this one: None found
Follow 6 latest changes.