bugFreeciv - Bugs: bug #15435, Potential bug in goto dialog

 
 
Show feedback again

bug #15435: Potential bug in goto dialog

Submitted by:  pepeto <pepeto>
Submitted on:  Sat 20 Feb 2010 07:21:37 PM UTC  
 
Category: client-gtk-2.0Severity: 2 - Minor
Priority: 3 - LowStatus: Fixed
Assigned to: pepeto <pepeto>Open/Closed: Closed
Release: S2_2, S2_1Operating System: None
Planned Release: 2.1.12, 2.2.1

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 25 Feb 2010 09:07:12 AM UTC, SVN revision 16924:

Use city id instead of name to the goto dialog in the gtk2 client.

See gna bug #15435

(Browse SVN revision 16924)

pepeto <pepeto>
Project MemberIn charge of this item.
Thu 25 Feb 2010 09:07:09 AM UTC, SVN revision 16923:

Use city id instead of name to the goto dialog in the gtk2 client.

See gna bug #15435

(Browse SVN revision 16923)

pepeto <pepeto>
Project MemberIn charge of this item.
Tue 23 Feb 2010 08:10:35 PM UTC, comment #3:

for xaw we need to keep a separate keymap for city-idsa and names

Vijay Kiran Kamuju <infyquest>
Project Member
Tue 23 Feb 2010 07:08:40 PM UTC, comment #2:

It appears that I forgot to upload the fixes...

(file #8233, file #8234)

pepeto <pepeto>
Project MemberIn charge of this item.
Tue 23 Feb 2010 06:31:59 PM UTC, comment #1:

Raised bug #15463 for client xaw issues. The SDL client already uses the city ids.

pepeto <pepeto>
Project MemberIn charge of this item.
Sat 20 Feb 2010 07:21:37 PM UTC, original submission:

When working on fix for bug #15313, I noticed that this dialog was working on city name. This might have not intentional behaviour in the case many cites would be named the same. Changed to use city ids.

Patch attached for S2_1 and S2_2. bug #15313 would fix this for trunk.

pepeto <pepeto>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by infyquest (Posted a comment)
  • -unavailable- added by pepeto (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 25 Feb 2010 09:07:23 AM UTCpepetoStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue 23 Feb 2010 07:08:40 PM UTCpepetoAttached File-=>Added S2_2_gtk2_gotodlg_use_city_id.diff, #8233
      Attached File-=>Added S2_1_gtk2_gotodlg_use_city_id.diff, #8234
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup