bugBattle for Wesnoth - Bugs: bug #16059, chat list keeps scrollin to the...

 
 
Show feedback again

bug #16059: chat list keeps scrollin to the end when receiving new chat

Submitted by:  FAAB <faabumc>
Submitted on:  Sat May 22 06:20:25 2010  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Multiplayer Lobby
Status: FixedPrivacy: Public
Assigned to: Charles Dang <vultraz>Open/Closed: Closed
Release: trunk rev 42756Operating System: gnu/linux

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed Mar 23 19:24:32 2016, comment #6:

I've applied and committed your patch, with some adjustments.

https://github.com/wesnoth/wesnoth/commit/e6495b929a30f7bf0f1837a37f1281607216892b

https://github.com/wesnoth/wesnoth/commit/5ea08ba37d49a48577b573a5d6c93d0507c27d19

Charles Dang <vultraz>
Project AdministratorIn charge of this item.
Tue May 25 13:14:47 2010, comment #5:

New patch taking remarks into account.

The link was a good read.
While I assume you link to it to highlight that a patch should be send as a patch and not attached in a bug report. I still attach here though as the previous logs are here. If I have to create a patch in the patch submission form, just let me know and I will fire one.

(file #9206)

FAAB <faabumc>
Project Member
Mon May 24 11:13:56 2010, comment #4:

Thanks for your patch, some remarks:
- please read http://forum.wesnoth.org/viewtopic.php?f=10&t=9979
- in Wesnoth we tabs for indention.
- member functions which don't modify the object should be const.

Best also rename move_vertical_scrollbar to set_vertical_scrollbar_item_position, since that how underlaying function is called.

Same for get_vertical_scrollbar_position.

Mark de Wever <mordante>
Project Member
Sat May 22 08:00:22 2010, comment #3:

Browsing more lobby issue reports, I found this comment that explains the new behavior of the lobby chat list (scroll to the end): https://gna.org/bugs/index.php?14741#comment4

FAAB <faabumc>
Project Member
Sat May 22 06:39:12 2010, comment #2:

I attach hereunder a patch to fix the described problem.
The patch implementation is:
- if the chat list is at the end, before a new message is sent, scroll it back to the end after the new message is appended
- if the chat list is anywhere (scrollbar has been used), then stores the current position of the scrollbar, append the chat message and scroll the scrollbar to the stored position.

The patch would have been straightforward if not for creating new helper functions in scrollbar_container.

The patch is tested with 2 instances in trunk MP server. I have applied the patch on the code 1.8 and I will test it as soon as the lobby is a bit animated.

PS: title's first word is "Chat"

(file #9193)

FAAB <faabumc>
Project Member
Sat May 22 06:27:09 2010, comment #1:

I have check the list of bugs for lobby 1.8 and it seems this one hasn't be reported yet.

When scrolling up the chat list in the MP lobby to read old chat, the list keeps scrolling to the end as soon as a new chat message is received.

While my report doesn't match the behavior reported here: https://gna.org/bugs/index.php?15764#comment2 still that is what we can observe in the current state of the lobby 1.8 too.

FAAB <faabumc>
Project Member
Sat May 22 06:20:25 2010, original submission:
FAAB <faabumc>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #9206:  patch-lobby-chatbox-scroll.diff added by faabumc (3kB - text/x-patch - New version, changes in remarks done)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by vultraz (Posted a comment)
  • -unavailable- added by mordante (Posted a comment)
  • -unavailable- added by faabumc (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri Jul 29 17:22:57 2016vultrazOpen/ClosedOpen=>Closed
    Wed Mar 23 19:24:32 2016vultrazStatusIn Progress=>Fixed
      Assigned tomordante=>vultraz
    Tue May 25 13:14:47 2010faabumcAttached File-=>Added patch-lobby-chatbox-scroll.diff, #9206
    Mon May 24 11:13:56 2010mordanteStatusNone=>In Progress
      Assigned toNone=>mordante
    Mon May 24 10:20:38 2010ivanovicItem GroupUser Interface=>Multiplayer Lobby
      Summaryhat list keeps scrollin to the end when receiving new chat=>chat list keeps scrollin to the end when receiving new chat
    Sat May 22 06:39:12 2010faabumcAttached File-=>Added patch-lobby-chatbox-scroll.diff, #9193
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup