bugpokersource - Bugs: bug #16756, Multi-sessions bug when returning...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #16756: Multi-sessions bug when returning to the tournament

Submitted by:  Vandemeulebroucke <ramboz>
Submitted on:  Fri 24 Sep 2010 09:05:51 PM UTC  
 
Category: poker-networkSeverity: 4 - Important
Priority: 5 - NormalStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Fri 01 Oct 2010 10:10:34 PM UTC, comment #4:

Index: pokertable.py
===================================================================
--- pokertable.py (révision 6569)
+++ pokertable.py (copie de travail)
@@ -1228,7 +1228,10 @@
#
# Sit back immediately, as if we just seated
#
- game.comeBack(serial)
+ if game.comeBack(serial):
+ if self.isSit(avatar):
+ self.broadcast(PacketPokerSit(game_id = game.id,
+ serial = serial))

avatar.join(self, reason = reason)

Vandemeulebroucke <ramboz>
Fri 01 Oct 2010 04:46:28 PM UTC, comment #3:

Hi,

Could you please let me know exactly where this patch is to be applied ? Did you run the test suite successfully ?

Thanks for your contribution

Loic Dachary <loic>
Project Administrator
Fri 01 Oct 2010 03:16:22 PM UTC, comment #2:

small fix :

if self.isSeated(avatar):
#
# Sit back immediately, as if we just seated
#
if game.comeBack(serial):
if self.isSit(avatar):
self.broadcast(PacketPokerSit(game_id = game.id,
serial = serial))

this bug is now fixed

Xavier.

Vandemeulebroucke <ramboz>
Tue 28 Sep 2010 10:59:51 PM UTC, comment #1:

I think I solved the problem

when a new session is created and we are sitting at a table, the method pokergame.comeBack is called by pokertable.joinPlayer.

this method apply player.auto = False

I just add notification to inform all players that we are now sitting

if self.isSeated(avatar):
#
# Sit back immediately, as if we just seated
#
game.comeBack(serial)
self.broadcast(PacketPokerSit(game_id = game.id,
serial = serial))

I would do more tests tomorrow

Xavier

Vandemeulebroucke <ramboz>
Fri 24 Sep 2010 09:05:51 PM UTC, original submission:

Hey,

i found a bug in multi-sessions context :

- player1 & player2 plays
- player1 sitout and enter in auto fold state
- player1 open a new session ; the game is restored and the player is on state "in game and plays"

player2 not received the PokerPacketSit :/

Vandemeulebroucke <ramboz>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by loic (Posted a comment)
  • -unavailable- added by ramboz (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup