bugBattle for Wesnoth - Bugs: bug #16850, 'enemies defeated' events fired at...

 
 
Show feedback again

bug #16850: 'enemies defeated' events fired at odd times

Submitted by:  Lari Nieminen <zookeeper>
Submitted on:  Sun 10 Oct 2010 09:27:25 PM UTC  
 
Category: Feature RequestSeverity: 3 - Normal
Priority: 5 - NormalItem Group: WML
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open
Release: trunkOperating System: win xp

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 20 Oct 2011 08:35:44 PM UTC, comment #2:

Changing to feature request like bug #16820. The bug part (enemies defeated fired every side turn if no longer any enemy leaders alive) doesn't make sense since existing wml could depend on it.

Anonymissimus <anonymissimus>
Project Member
Fri 12 Aug 2011 06:11:42 PM UTC, comment #1:

Well...after thinking high and low around this and the related bug #16820 and patch #2241...
Does it make sense to fix this "bug" ? It could for instance be fixed by basically using first_time_only=true on the C++ side. But it would make the event less useful. It is fired at the correct time, that is, when the last enemy leader dies, since check_victory is called after every fight. Usually it's first_time_only=yes in this event so it isn't noticable.
Perhaps someone has some wml based on this event firing on the subsequent (side) turns which would break ?
(Of course I also noticed that it's much harder to fix than expected, especially taking into consideration silene's post in patch #2241...)

Anonymissimus <anonymissimus>
Project Member
Sun 10 Oct 2010 09:27:25 PM UTC, original submission:

'enemies defeated' events seem to be fired whenever the player ends their turn, if there are no enemy leaders present at that time.

The sensible behaviour would be to fire them only at the same times when a die event for a leader would also be fired. That is, when the last enemy leader is killed in combat or [kill]ed with fire_event=yes.

Lari Nieminen <zookeeper>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by anonymissimus (Posted a comment)
  • -unavailable- added by zookeeper (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 20 Oct 2011 08:35:44 PM UTCanonymissimusCategoryBug=>Feature Request
    Fri 12 Aug 2011 06:21:47 PM UTCanonymissimusAssigned toanonymissimus=>None
    Thu 11 Aug 2011 04:03:44 PM UTCanonymissimusAssigned toNone=>anonymissimus
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup