bugFreeciv - Bugs: bug #17096, Freeland: assertion 'v1 < count...

 
 
Show feedback again

bug #17096: Freeland: assertion 'v1 < count && v2 < count && v3 < count' failed.

Submitted by:  Daniel Markstedt <dmarks>
Submitted on:  Wed 17 Nov 2010 05:30:33 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: S2_3Operating System: None
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 20 Mar 2011 11:51:02 AM UTC, comment #2:

I'm not entirely sure I believe this assertion is valid.

I think v1/v2/v3 index (tileset_layer)->match_types[], which is a dynamically allocated array with no hard limit. In particular, I don't think that it's limited by (drawing_layer)->match_indices, which is what I think this assertion is asserting.

In this case I'm guessing it's firing as a knock-on effect of (drawing_layer)->match_indices having been truncated by the code that's fixed by bug #17095, presumably to less than (tileset_layer)->match_count.

Perhaps it's the case that there can't usefully be more match_types than match_indices; I don't understand this matching stuff well enough to comment on that. If so, the condition should be enforced by an assertion in tileset_read_toplevel(), rather than leaving it to fall through to tileset_setup_tile_type().

Jacob Nevins <jtn>
Project Administrator
Tue 15 Mar 2011 06:59:20 AM UTC, comment #1:

These assertions disappear with the same patch that resolve bug #17095

Peter Arbor <parbor>
Project Member
Wed 17 Nov 2010 05:30:33 AM UTC, original submission:

Playing a game with the Freeland (small size) tileset results in hundreds of these assertions:

1: in tileset_setup_tile_type() [tilespec.c::3037]: assertion 'v1 < count && v2 < count && v3 < count' failed.
1: Please report this message at http://gna.org/projects/freeciv/

Using this work-in-progress test version I pieced together using the 3.0-alpha version the author released a couple of years ago. http://download.gna.org/freeciv/incoming/freeland-2.2.99-debug.tar.gz

Daniel Markstedt <dmarks>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by parbor (Posted a comment)
  • -unavailable- added by dmarks (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 25 Jan 2014 01:58:40 PM UTCjtnPlanned Release2.4.0=>
    Sat 30 Jul 2011 04:10:53 PM UTCjtnPlanned Release2.3.0, 2.4.0=>2.4.0
    Sun 20 Mar 2011 12:43:57 AM UTCdmarksPlanned Release=>2.3.0, 2.4.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup