bugFreeciv - Bugs: bug #17862, Hardcoded GAME_START_YEAR

 
 
Show feedback again

bug #17862: Hardcoded GAME_START_YEAR

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Mon 07 Mar 2011 09:36:51 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.3.4, 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 24 Jan 2013 10:19:01 PM UTC, SVN revision 22206:

Send string "Calendar not set up" to metaserver in pregame instead
of hardcoded year -4000.

See gna bug #17862

(Browse SVN revision 22206)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 24 Jan 2013 10:18:51 PM UTC, SVN revision 22205:

Send string "Calendar not set up" to metaserver in pregame instead
of hardcoded year -4000.

See gna bug #17862

(Browse SVN revision 22205)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 24 Jan 2013 10:18:44 PM UTC, SVN revision 22204:

Send string "Calendar not set up" to metaserver in pregame instead
of hardcoded year -4000.

See gna bug #17862

(Browse SVN revision 22204)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 22 Jan 2013 11:03:46 PM UTC, comment #5:

Patches to send string "Calendar not set up" instead of any numerical year value in pregame.

(file #16998, file #16999)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 12 Oct 2012 11:03:37 PM UTC, SVN revision 21933:

Allow MinYear requirement with year earlier than hardcoded -4000.

See gna bug #17862

(Browse SVN revision 21933)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 12 Oct 2012 11:03:33 PM UTC, SVN revision 21932:

Allow MinYear requirement with year earlier than hardcoded -4000.

See gna bug #17862

(Browse SVN revision 21932)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 12 Oct 2012 11:03:27 PM UTC, SVN revision 21931:

Allow MinYear requirement with year earlier than hardcoded -4000.

See gna bug #17862

(Browse SVN revision 21931)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 07 Oct 2012 06:49:25 AM UTC, comment #1:

Fix attached for the "MinYear" requirement case. Simply allow any value.

We couldn't force value to be at least start year in effects loading even if we wanted. Calendar, and start year, is not yet set up at that point. We could add check to ruleset sanity module, but as year has no gameplay effects at all, I don't think that's necessary - maybe someone even wants to implement countdown style calendar where years decreases as turn increases.

(file #16658)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 07 Mar 2011 09:36:51 PM UTC, original submission:

There's still macro GAME_START_YEAR with value -4000 used in some places. Regardless of what ruleset defines as start year, metaserver shows -4000 as current year for pregame games. "MinYear" requirement with value less than -4000 is always considered invalid (even if start year defined in ruleset is less)

Metasever issue at least is not trivial to fix. In pregame ruleset, with start year definition, is still subject to change.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16998:  MetaCalendarSetup.patch added by cazfi (658B - text/x-diff)
file #16658:  Pre4000BCMinYear.patch added by cazfi (550B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 24 Jan 2013 10:19:26 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Tue 22 Jan 2013 11:03:46 PM UTCcazfiAttached File-=>Added MetaCalendarSetup.patch, #16998
      Attached File-=>Added MetaCalendarSetup-S2_3.patch, #16999
      CategoryNone=>general
      StatusNone=>Ready For Test
      Planned Release=>2.3.4, 2.4.0, 2.5.0
    Sun 07 Oct 2012 06:49:25 AM UTCcazfiAttached File-=>Added Pre4000BCMinYear.patch, #16658
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup