bugMyPaint - Bugs: bug #17940, Color picker (ctrl) makes problem...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #17940: Color picker (ctrl) makes problem with new docked interface

Submitted by:  David REVOY <deevad>
Submitted on:  Thu 24 Mar 2011 12:45:30 PM UTC  
 
Severity: 2 - MinorPriority: 5 - Normal
Status: FixedPrivacy: Public
Assigned to: Andrew Chadwick <achadwick>Open/Closed: Closed
Release: 0.9 Git masterPlanned Release: None
Operating System: LinuxMint 64bit LTS Lucid

(Jump to the original submission Jump to the original submission)

Thu 06 Dec 2012 07:57:16 PM UTC, comment #10:

Sure Andrew, This old bug was fixed on comment #6 by you last year and I didn't saw this behavior since this time.
I tried on actual with all color selectors available ; no issues.
Can be closed.

David REVOY <deevad>
Project Member
Thu 06 Dec 2012 06:33:54 PM UTC, comment #9:

Does not affect the current stable release + Fixed => Closed.

Although the fix bit us again with bug #20279 and had to be rewritten/partly reverted. So this might only be a temporary state of affairs.

David: can you confirm that

<deevad> 1. Paint color , 2 use Ctrl+stylus nib to select a color release ctrl and stylus 3. try to change color in a docked color triangle , or change option on top menu , or a layer in a docked Layer panel ... you can't
<deevad> with mouse = no problem
<deevad> with stylus

from comment 2 cannot be reproduced with the current git master? I wasn't able to reproduce it with my stylus this time, using the GTK triangle tab or any of the new-style selectors. If it can, please reopen.

Andrew Chadwick <achadwick>
Project AdministratorIn charge of this item.
Fri 25 Mar 2011 10:02:42 PM UTC, comment #8:

Nice solution, thanks for the fix! :-)

Martin Renold <martinxyz>
Project Administrator
Fri 25 Mar 2011 10:04:01 AM UTC, comment #7:

Thanks that was fast and it works now very well, color picker seams even faster to release on my system, and I can access all option and Ui after color pick now.

And guess what ? it also look like it solve the video recording problem with the remaining color picker display. ( Griatch will be happy too as he experienced the same into his video tutorials ). I tested only on a 20min speedpainting temp video recording and no display problem.

Thanks again

David REVOY <deevad>
Project Member
Fri 25 Mar 2011 05:07:14 AM UTC, comment #6:

Agreed, redrawing just to set a cursor is pretty dumb. Fixed in http://gitorious.org/mypaint/mypaint/commit/821f5705660aa9379e4c219e7bf2d3a29f9e1eee which introduces an override cursor for the tdw.

All looks good now when I turn on Visualize Rendering: no re-rendering at all for me in Compiz, and just exposed areas in Metacity.

Andrew Chadwick <achadwick>
Project AdministratorIn charge of this item.
Fri 25 Mar 2011 02:38:48 AM UTC, comment #5:

There is a problem with that commit: it adds this main_widget.set_sensitive() call that is causing a full canvas redraw. When working with a big image fullscreen this takes too much time; the color picker is something that must respond very fast. You can also enable “visualize rendering” in the debug menu to see the effect, or just work on a big image fullscreen and zoomed out.

I just checked GTK source: set_sensitive() always does queue_draw() if the widget is visible and mapped, so we better don't call it.

Martin Renold <martinxyz>
Project Administrator
Fri 25 Mar 2011 12:21:46 AM UTC, comment #4:

David: this should be fixed now. Can you test again with the latest git head?

Using a grab at the GTK level rather than the GDK equivalent seems a good workaround on my system: http://gitorious.org/mypaint/mypaint/commit/61cce3b533ba21d1d84797f66f0e73a5851b55a7 works much more nicely with a tablet. Tested with xephyr and xorg, under a few random WMs, and it seems to behave.

(Weird GTK stuff: you can still grab colours outside the window under Compiz/X11. More bizarrely, even the pointer stays as an eyedropper. Suspect keeping a key pressed during a GTK-level grab makes it behave itself better for this sort of thing.)

Andrew Chadwick <achadwick>
Project AdministratorIn charge of this item.
Thu 24 Mar 2011 10:13:25 PM UTC, comment #3:

Confirmed here, just as described in David's explanation in comment 1. Compiz, python-gtk2 2.21.0-0ubuntu1 and a Wacom Bamboo MTE-450A.

Additionally if you put the pen down on the gtk colour triangle, it updates the "last colour painted with" box. Panning the canvas right to reveal where you just clicked reveals why - there's a dollop of the colour you just chose off the canvas right there under your last pen stroke D:

This feels like like a pointer grab issue with the colour picker, though that claims to be leaving "picker state" and pointer_ungrab()-ing like it should even with extended input devices.

Andrew Chadwick <achadwick>
Project AdministratorIn charge of this item.
Thu 24 Mar 2011 01:15:43 PM UTC, comment #2:

Tablet : Wacom Intuos4 6x9
PyGTK : python-gtk2 , 2.21.0-0ubuntu1

David REVOY <deevad>
Project Member
Thu 24 Mar 2011 01:12:01 PM UTC, comment #1:

From IRC

<achadwick> I can't reproduce it here :/
<deevad> oh, too bad
[...]
<achadwick> I'm trying: 1. paint colours, 2. use ctrl+left mouse to pick, 3. while ctrl is still pressed & left button pressed hover the cursor over the GTK colour triangle (goes crazy :) 4. release either ctrl or left mouse button.
<deevad> achadwick: I will redetail it, 2 min to write it
<achadwick> It goes crazy because it's drawing a black circle and then averaging that colour, which changes the colour and round we go again...! But I expect that.
<deevad> 1. Paint color , 2 use Ctrl+stylus nib to select a color release ctrl and stylus 3. try to change color in a docked color triangle , or change option on top menu , or a layer in a docked Layer panel ... you can't
<deevad> with mouse = no problem
<deevad> with stylus
<achadwick> Hmm. Admittedly I'm using a mouse here, and I won't be able to try with a stylus until I get home from work.

Andrew Chadwick <achadwick>
Project AdministratorIn charge of this item.
Thu 24 Mar 2011 12:45:30 PM UTC, original submission:

Hi,

Step to reproduce ( with widget docked : color triangle , layer ) :
Paint on canvas,
color pick with ctrl then immediately
try to select a color on the "color triangle" ;
- the color picker is like frozen.
- same for layer panel
- same for other Ui elements ( top menu bar )

Workaround : don't dock panel, but Ui ( top menu bar can't be undocked, so this one still freeze )

( Note : I have the color picker icon that keeps displaying while video screen capturing Mypaint, had to do with this problem when doing my last DVD , is the problem related with the color picker ? is an X11 problem or GTK or ffmpeg ? Other software don't have similar issues )

David REVOY <deevad>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by martinxyz (Posted a comment)
  • -unavailable- added by achadwick (Posted a comment)
  • -unavailable- added by deevad (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 06 Dec 2012 06:33:54 PM UTCachadwickSeverity4 - Important=>2 - Minor
      Open/ClosedOpen=>Closed
    Sun 10 Jul 2011 05:21:05 PM UTCachadwickStatusReady For Test=>Fixed
    Fri 25 Mar 2011 12:21:57 AM UTCachadwickAssigned toNone=>achadwick
    Fri 25 Mar 2011 12:21:46 AM UTCachadwickStatusConfirmed=>Ready For Test
    Thu 24 Mar 2011 10:13:25 PM UTCachadwickStatusNone=>Confirmed
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup