There are 4 scaling-related bugs:

• Portraits get scaled when they don't need to be.
  • Fixed in r52205.
• Portraits get scaled rather than cropped above 500px when there's no room.
  • No other bug filed.
• Too-large portraits occasionally crash the game.
  • Bug #18686.
• Misuse of scaling algorithms.
  • Minimap should not use interpolation, main menu background, story art and portraits should. (main menu is broken, not sure about the rest)
  • No other bug filed.

Also attaching a 1.8 screenshot for reference.

(file #14842)

Espreaon just mentioned that it is not a dupe, so marking it as postponed till past 1.10 is branched off...

I talked with Jetrel regarding the wishes of the portraits before coding. In
the original specification, there was only the wish to scale portraits, not to
crop them. So I designed the engine according to these specifications.

So at the moment it needs quite a bit of work to change how it works. Since
there are a lot of other GUI2 things to be done, this has a low priority for
me. Also I don't consider it a bug.

I designed the dialog to only scale and not to crop, so the fact that rithrandil is scaled on several screens is by design.

Add test case for bug #17961 and bug #18686 to test scenario

(Browse SVN revision 52235)

Bumping up to blocker as we do not want to release 1.10 with portraits looking like this.

There are two issues here:
1. Portraits are scaled when there is no need to do so. This was probably introduced along with extremely tall portraits (> 500 px, like the wose) as a temporary fix. Wanted behavior:
-Scale down to 500px wide if wider.
-Crop down to screen height if (still) too tall.

2. The scaling algorithm messes up the minimap by sampling from pixels not in the hex. The scaling algorithm was then re-broken to fix this, which re-worsened any scaling for portraits and such.

So, fixes that are needed:
1. Change GUI2 to make portraits work as wanted.
2. Specialize the scaling algorithm to work for the minimap, then re-enable the proper sampling.

OK, I think I understand:

A. Dec. 10th -> 1.9.3

B. Dec. 19th -> r47967

C. Jan. 17th -> 1.9.4 -> Did r47967 make the portraits smoother in 1.9.4 than they were in 1.9.3?

D. March 12th -> r47967 is undone, hard edges restored for editor

E. March 27th -> 1.9.5 -> Did action "D" make 1.9.5 have same portraits as 1.9.3?

I'll have to re-install 1.9.3, so I don't yet know. But AI (in my forum link below) said the portraits should not be getting scaled at all for normal screen sizes, so isn't the real problem older than 1.9.3?

There must be a typo in your link, mordante, it leads to a 2004 post about ghosts. I didn't notice much of a difference between 1.9.3 and 1.9.4, but I will check. What I did notice was:
1.9.2 vs 1.9.3, images got scaled down
1.9.4 vs 1.9.5, image quality decreased

- doofus-01

Starting in 1.9.3, the portraits got scaled down severely, at least for some screen sizes. In 1.9.5, the scaling method degrades the images more than it did in 1.9.3 and 1.9.4. But they should not get scaled at all? Please see forum post:
http://forum.wesnoth.org/viewtopic.php?f=5&t=33422&p=483567#p483567