bugFreeciv - Bugs: bug #18191, transfer_city() callers are not...

 
 
Show feedback again

bug #18191: transfer_city() callers are not prepared for city destruction

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Tue 07 Jun 2011 08:59:47 AM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: Operating System: None
Planned Release: 2.4.1, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 30 Jan 2013 01:24:31 AM UTC, comment #2:

> I can't see an obvious script hook -- is it during incidental
> changes like unit movements?


Unit bouncing or wiping.

Marko Lindqvist <cazfi>
Project Administrator
Fri 18 Nov 2011 09:48:26 PM UTC, comment #1:

Still looks true, big job, not going to make 2.3.1...
(Is it only scripting that can cause city destruction during transfer_city()? If so, at what point? I can't see an obvious script hook -- is it during incidental changes like unit movements?)

Jacob Nevins <jtn>
Project Administrator
Tue 07 Jun 2011 08:59:47 AM UTC, original submission:

transfer_city() itself consider the possibility that scripting causes city to be destroyed in the process. Callers on the other hand happily use old pcity-pointer after call to transfer_city().

Marko Lindqvist <cazfi>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 04 Aug 2013 08:40:31 PM UTCcazfiPlanned Release2.4.0=>2.4.1, 2.5.0, 2.6.0
    Fri 18 Nov 2011 09:48:26 PM UTCjtnPlanned Release2.3.1, 2.4.0=>2.4.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup