bugFreeciv - Bugs: bug #18191, transfer_city() callers are not...

 
 
Show feedback again

bug #18191: transfer_city() callers are not prepared for city destruction

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Tue Jun 7 08:59:47 2011  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: pepeto <pepeto>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.5.0, 2.6.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon Jul 21 08:17:59 2014, SVN revision 25667:

Prepare transfer_city() callers for city destruction.

Reported by Marko Lindqvist

See gna bug #18191

(Browse SVN revision 25667)

pepeto <pepeto>
Project MemberIn charge of this item.
Mon Jul 21 08:17:55 2014, SVN revision 25666:

Prepare transfer_city() callers for city destruction.

Reported by Marko Lindqvist

See gna bug #18191

(Browse SVN revision 25666)

pepeto <pepeto>
Project MemberIn charge of this item.
Sat Jul 19 14:30:04 2014, comment #3:

Patches attached.

(file #21466, file #21467)

pepeto <pepeto>
Project MemberIn charge of this item.
Wed Jan 30 01:24:31 2013, comment #2:

> I can't see an obvious script hook -- is it during incidental
> changes like unit movements?


Unit bouncing or wiping.

Marko Lindqvist <cazfi>
Project Administrator
Fri Nov 18 21:48:26 2011, comment #1:

Still looks true, big job, not going to make 2.3.1...
(Is it only scripting that can cause city destruction during transfer_city()? If so, at what point? I can't see an obvious script hook -- is it during incidental changes like unit movements?)

Jacob Nevins <jtn>
Project Administrator
Tue Jun 7 08:59:47 2011, original submission:

transfer_city() itself consider the possibility that scripting causes city to be destroyed in the process. Callers on the other hand happily use old pcity-pointer after call to transfer_city().

Marko Lindqvist <cazfi>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pepeto (Updated the item)
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon Jul 21 08:18:16 2014pepetoStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sat Jul 19 14:30:04 2014pepetoAttached File-=>Added S2_5_transfer_city+script.patch, #21467
      StatusNone=>Ready For Test
      Assigned toNone=>pepeto
    Sat Jul 19 14:30:03 2014pepetoAttached File-=>Added trunk_transfer_city+script.patch, #21466
    Tue May 13 21:02:11 2014cazfiPlanned Release2.4.1, 2.5.0, 2.6.0=>2.5.0, 2.6.0
    Sun Aug 4 20:40:31 2013cazfiPlanned Release2.4.0=>2.4.1, 2.5.0, 2.6.0
    Fri Nov 18 21:48:26 2011jtnPlanned Release2.3.1, 2.4.0=>2.4.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup