bugFreeciv - Bugs: bug #18476, allow to load games without a map...

 
 
Show feedback again

bug #18476: allow to load games without a map (i.e. tutorial)

Submitted by:  Matthias Pfafferodt <syntron>
Submitted on:  Tue 09 Aug 2011 10:34:42 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Works For Me
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 07 Jul 2012 10:03:24 AM UTC, comment #3:

What's the case where this patch is needed? It checks against is_new_game, which would indicate that any game saved in pregame would be affected. I saved in pregame, and loaded without this patch, and everything seemed to work.
It seems that while the funcions this patch protects from being called when is_new_game are themselves checking against it already.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 24 Jun 2012 08:58:55 PM UTC, comment #2:

No objection from me -- I was thinking along the same lines.

Jacob Nevins <jtn>
Project Administrator
Wed 20 Jun 2012 11:19:47 PM UTC, comment #1:

It occurred to me that someone may consider this a scenario format change (new kinds of scenarios allowed) and thus not something we should do after datafile format freeze. I myself consider this a bugfix fixing kinds of scenarios that were supposed to be working already. Any objections?

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 09 Aug 2011 10:34:42 PM UTC, original submission:

needed for the lua test game and for a possible tutorial using the new savegame format

Matthias Pfafferodt <syntron>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Updated the item)
  • -unavailable- added by syntron (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 13 May 2014 09:03:25 PM UTCcazfiStatusReady For Test=>Works For Me
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Mon 23 Jul 2012 10:11:03 PM UTCcazfiAssigned tocazfi=>None
    Mon 18 Jun 2012 10:48:28 PM UTCcazfiStatusNone=>Ready For Test
      Assigned toNone=>cazfi
      Planned Release2.4.0=>2.4.0, 2.5.0
    Tue 09 Aug 2011 10:34:42 PM UTCsyntronAttached File-=>Added 20110809-luascript19-allow-to-load-games-without-a-map.patch, #13815
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup