bugFreeciv - Bugs: bug #18517, unable to drag items in Target...

 
 
Show feedback again

bug #18517: unable to drag items in Target Worklist to reorder.

Submitted by:  Dennis <thenerd>
Submitted on:  Wed 17 Aug 2011 12:27:26 PM UTC  
 
Category: client-gtk-2.0Severity: 2 - Minor
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: 2.3.0-RC2,2.3.0Operating System: Microsoft Windows
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun 02 Feb 2014 03:09:41 PM UTC, comment #21:

Just to be sure, I tried this in cproc's r24327 test build (pre-2.4.2) and it was fine. (Probably already released ones are fine too, I didn't test.)

Jacob Nevins <jtn>
Project Administrator
Mon 27 Jan 2014 12:38:04 AM UTC, comment #20:

> Shall we declare this fixed, even if we never established root
> cause?


Nobody has objected. (We don't seem to have "Bug not in Freeciv", or similar, resolution status)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 21 Aug 2013 10:22:38 PM UTC, comment #19:

Shall we declare this fixed, even if we never established root cause?
We seem to have fixed it on Windows by care with choosing Gtk version; and we never saw it on Linux.

Jacob Nevins <jtn>
Project Administrator
Thu 02 May 2013 05:56:10 PM UTC, comment #18:

With GTK+ bundle 2.24.10 it seems to work, too.

Christian Prochaska <cproc>
Project Administrator
Sat 20 Apr 2013 10:17:06 AM UTC, comment #17:

Tested with crosser build that uses gtk+-2.24.10. Reordering by dragging seems to work.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 19 Apr 2013 08:18:18 PM UTC, comment #16:

I just tested this with freeciv trunk built against crosser-0.10.1, and couldn't reproduce. Maybe gtk+ has been fixed? Version in crosser-0.10.1 is 2.24.14.
Latest gtk+2 bundle for windows has 2.24.10. Our earlier testing indicates that bug was present in as late version as 2.24.4, but we don't have any data points after that.

I'll try to make crosser build that uses 2.24.10 for testing.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 28 Nov 2011 08:40:02 PM UTC, comment #15:

I confirm that dragging/dropping to reorder the list works with that Windows installer (as expected).

Jacob Nevins <jtn>
Project Administrator
Sun 27 Nov 2011 11:42:32 PM UTC, comment #14:

I've reverted to GTK+ 2.16.6 for my upcoming 2.3.1 Windows build and dropping seems to work fine again: http://download.gna.org/freeciv/packages/windows/testing/Freeciv-2.3.1-20111127-win32-gtk2-setup.exe

Christian Prochaska <cproc>
Project Administrator
Wed 28 Sep 2011 06:51:52 AM UTC, comment #13:

@thenerd there's also reorder arrows on the separator bar, being vertical (up & down).

I much prefer drag & dropping though. :\

DynV <dynv>
Wed 31 Aug 2011 08:52:41 PM UTC, comment #12:

Ah, that's better. New data: for all three old versions (2165, 2180, 2189), identical results:

  • dragging in the production dialog works
  • probably unrelated oddities with graphics:
    • on the worklist, icons for warriors etc tended to flick in and out of existence as the cursor moved
    • on the Nations report, the flags weren't displayed at all
    • all other images/icons that I looked at were displayed fine

So, for crosser builds at least, trouble starts somewhere between 2.18.9 and 2.20.1.

Jacob Nevins <jtn>
Project Administrator
Tue 30 Aug 2011 07:58:26 PM UTC, comment #11:

Oh, since I had not adjusted gdk-pixbuf version number, setup.bat was not generated with correct commands.

For gdk-pixbuf versions prior to 2.22.0, correct would be:
bin\gdk-pixbuf-query-loaders.exe > etc\gtk-2.0\gdk-pixbuf.loaders

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 29 Aug 2011 11:29:19 AM UTC, comment #10:

Sorry for the delay. Unfortunately, I've got no extra data on this bug.

I couldn't get freeciv-gtk2.exe to run with any of the winstacks at all (2165/2180/2189) -- nothing happened when I ran it from the command prompt.

This is similar to what happens if I forget to run setup.bat from winstack. I noticed that setup.bat was slightly wrong in all of these winstacks, presumably due to the gdk-pixbuf difference you mentioned; setup.bat tries to run:

but lib\gdk-pixbuf-2.0\ doesn't exist.

lib\gtk-2.0\ looked like a plausible replacement (containing 2.10.0\loaders\ folders), so I tried running the above command with "gtk-2.0" replacing "gdk-pixbuf-2.0", but it didn't help. I also tried manually creating lib\gdk-pixbuf-2.0\2.10.0.

freeciv-sdl.exe and freeciv-server.exe were fine (the latter with a warning "exchndl.dll could not be loaded, no crash debugger"), but that doesn't help us here :(

> You may want to test also if combination of above freeciv
> compiled against gtk+ 2.16.5 (compatible with any gtk2 version
> above 2.16.5) and dllstack binaries with later gtk+ version
> work (I would be very surprised if it would, but...)

As you expected, it doesn't work. All of freeciv-{gtk2,sdl,server} die with errors like:

Jacob Nevins <jtn>
Project Administrator
Sun 21 Aug 2011 09:46:01 PM UTC, comment #9:

> http://www.cazfi.net/~cazfi/fcwin/winstack-gtk2189.zip
> http://www.cazfi.net/~cazfi/fcwin/winstack-gtk2180.zip

Also snarfed.

Jacob Nevins <jtn>
Project Administrator
Sun 21 Aug 2011 09:35:10 PM UTC, comment #8:

> I'm already building also gtk+ 2.18.9 version


http://www.cazfi.net/~cazfi/fcwin/winstack-gtk2189.zip

and 2.18.0:
http://www.cazfi.net/~cazfi/fcwin/winstack-gtk2180.zip

Freeciv earlier built against older gtk+ version (2.16.5) should work with newer ones.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 21 Aug 2011 08:14:24 PM UTC, comment #7:

> Due to limited diskspace these are available for short time only
> for pinpointing this problem:
> http://www.cazfi.net/~cazfi/fcwin/winstack-gtk2165.zip
> http://www.cazfi.net/~cazfi/fcwin/freeciv-2.3.0+-r20171.zip

Grabbed, although I probably won't try them tonight.

Jacob Nevins <jtn>
Project Administrator
Sun 21 Aug 2011 07:48:21 PM UTC, comment #6:

> Christian's builds
> 2.3.0-RC1 OK (libgtk-win32-2.0-0.dll = 2.16.5)


So, if the deciding factor indeed is gtk+ version, latest crosser development version with gtk+ downgraded to 2.16.5 should work. Newer gtk+ was not even dependency for anything so gtk+ version really was all I changed (well, gtk+ 2.16.5 still had gdk-pixbuf built in, so I couldn't build (gtk+ 2.16.5) and (gdk-pixbuf 2.22.1 and gtk+ 3.0.12) but I had to completely disable gtk+ 3 build))

Due to limited diskspace these are available for short time only for pinpointing this problem:
http://www.cazfi.net/~cazfi/fcwin/winstack-gtk2165.zip
http://www.cazfi.net/~cazfi/fcwin/freeciv-2.3.0+-r20171.zip

You may want to test also if combination of above freeciv compiled against gtk+ 2.16.5 (compatible with any gtk2 version above 2.16.5) and dllstack binaries with later gtk+ version work (I would be very surprised if it would, but...)

I'm already building also gtk+ 2.18.9 version in the hope that we can eventually find out exact change in gtk+ that broke this, and to check if it's gtk+ bug or bug in the way we use gtk+.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 20 Aug 2011 12:56:45 PM UTC, comment #5:

@cazfi: this doesn't work in any of your crosser builds that I tried (even ones predating RC1).

Here's the results of my experiments so far:

  • Windows
    • Christian's builds
      • 2.3.0-RC1 OK (libgtk-win32-2.0-0.dll = 2.16.5)
      • 2.3.0-RC2 and -final bad (libgdk-win32-2.0-0 = 2.22.1)
    • Marko's builds
      • S2_3_r19844 + winstack-0.6.4 bad (libgdk-win32-2.0-0.dll = 2.20.1)
      • S2_3 RC1+-r20033 + winstack-0.6.5.103 bad (libgtk-win32-2.0-0.dll = 2.24.4)
      • Also 2.3.0 and 2.3.99-dev-r20045 with the latter winstack are bad.
  • Linux
    • S2_3 r20165 on Ubuntu 10.04 OK (libgtk2.0-0 2.20.1-0ubuntu2)
    • S2_3 r20165 on Ubuntu 10.10 OK (libgtk2.0-0 2.22.0-0ubuntu1)

So, inasmuch as it's correlated with anything, it seems correlated with Gtk version, but only on Windows. (I haven't checked what extra patches Ubuntu might have applied to Gtk, nor guessed whether it might be correlated with a component other than Gtk.)

Jacob Nevins <jtn>
Project Administrator
Thu 18 Aug 2011 11:00:45 AM UTC, comment #4:

Thanks for pointing out the up / down arrows Jacob. I did not see them. Is there any other information I can provide to help? I see that you've been able to reproduce so that should make it easier :)

Dennis <thenerd>
Wed 17 Aug 2011 10:28:07 PM UTC, comment #3:

> Looking at the various DLLs (e.g., libgtk-win32-2.0-0.dll), the > change in behaviour seems correlated with DLL versions


Are my crosser-based builds affected? Or do you want me to make some test builds of crosser+freeciv with specific gtk+ (or other component) versions?

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 17 Aug 2011 09:52:12 PM UTC, comment #2:

Looking at the various DLLs (e.g., libgtk-win32-2.0-0.dll), the change in behaviour seems correlated with DLL versions: the DLLs are different between RC1 and RC2, and the same in RC2/final. I think the RC2/final ones are newer.

Jacob Nevins <jtn>
Project Administrator
Wed 17 Aug 2011 09:38:54 PM UTC, comment #1:

Also reported by someone else on the forum.

I couldn't reproduce anything like this in Linux. However, I have reproduced it with the Windows installer builds -- in 2.3.0-RC1 (and also 2.2.7), I can drag to reorder items on the worklist, but in 2.3.0-RC2 and 2.3.0-final, I can't; I can pick up the item and drag it around, but attempting to drop it, it just moves back to its original location as if it were an invalid drop location.

Bizarre. I can't think what we changed to cause this.

(BTW, there is a way to reorder the worklist without dragging -- there are tiny up and down arrows between the "worklist" and "available items" panes, which move the selected item on the worklist.)

Jacob Nevins <jtn>
Project Administrator
Wed 17 Aug 2011 12:27:26 PM UTC, original submission:

Since the update to 2.3 it appears that one can no longer drag items in the Target Worklist to reorder them. I've only tried this using the GTK client on Windows 7 x64.

The only way to re-order is by removing an item(s) and then re-adding them in the proper order.

Dennis <thenerd>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cproc (Posted a comment)
  • -unavailable- added by dynv (Posted a comment)
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by thenerd (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 27 Jan 2014 12:38:04 AM UTCcazfiStatusNone=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Wed 17 Aug 2011 09:39:18 PM UTCjtnRelease2.3.0-RC2=>2.3.0-RC2,2.3.0
    Wed 17 Aug 2011 09:38:54 PM UTCjtnRelease2.3=>2.3.0-RC2
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup