Freeciv - Bugs: bug #18641, allow remove command for access... [Gna!]

Freeciv - Bugs: bug #18641, allow remove command for access...

Group

Main
- Main
- View Members
- Search
Homepage
Download
Docs
- Browse
- Submit
- Edit
- Digest
- Export
- Search
Mailing Lists
Source Code
- Use Subversion
- Browse Sources Repository
Bugs
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search
Tasks
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search
Patches
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search

Show feedback again

bug #18641: allow remove command for access level >= ADMIN in running games

Submitted by:	Michal Mazurek <akfaew>
Submitted on:	Sun 11 Sep 2011 09:49:14 AM UTC

Category:	general	Severity:	3 - Normal
Priority:	5 - Normal	Status:	Fixed
Assigned to:	Matthias Pfafferodt <syntron>	Open/Closed:	Closed
Release:	S2.3	Operating System:	None
Planned Release:	2.3.2,2.4.0

Add a New Comment (Rich Markup):

You are not logged in

Please log in, so followups can be emailed to you.

( Jump to the original submission)

Sat 19 Nov 2011 10:38:30 PM UTC, comment #16: ...and it's back post-2.3.1, on the assumption that we'll fix the problems before 2.3.2.	Jacob Nevins <jtn>
Sat 19 Nov 2011 10:35:05 PM UTC, SVN revision 20605: Results of running "make update-po" after reinstating fix for gna bug #18641. (Browse SVN revision 20605)	Jacob Nevins <jtn>
Sat 19 Nov 2011 10:34:51 PM UTC, SVN revision 20604: Allow remove command for access level >= ADMIN in running games (again) Reinstated fix after 2.3.1 release. See gna bug #18641. (Browse SVN revision 20604)	Jacob Nevins <jtn>
Sat 19 Nov 2011 07:40:09 PM UTC, SVN revision 20595: Reinstate the string removed and then replaced under gna bug #18641 in translations that have been updated since then (and have cleared out their obsolete translations). The translations came out of old svn versions. (Browse SVN revision 20595)	Jacob Nevins <jtn>
Sat 19 Nov 2011 07:40:02 PM UTC, SVN revision 20594: Temporarily revert fix for gna bug #18641 on stable branch. It exposes another bug (gna bug #18776) that's too late to fix for 2.3.1. (Browse SVN revision 20594)	Jacob Nevins <jtn>
Sat 19 Nov 2011 05:12:15 PM UTC, comment #11: I'm going to temporarily revert this fix for 2.3.1 as it exposes other bugs. See bug #18776 comment 32.	Jacob Nevins <jtn>
Tue 08 Nov 2011 08:53:42 PM UTC, SVN revision 20502: [S2_3] allow remove command for access level >= ADMIN in running games Fix error message if trying "/remove" with game start. See gna bug #18641. patch by me with fix for the patch by Jacob Nevins git-svn-id: svn://svn.gna.org/svn/freeciv/trunk@20278 a0f10bec-cc02-0410-94fc-a9cfff90b4cd git-svn-id: svn://svn.gna.org/svn/freeciv/trunk@20329 a0f10bec-cc02-0410-94fc-a9cfff90b4cd (Browse SVN revision 20502)	Matthias Pfafferodt <syntron>
Mon 31 Oct 2011 06:39:37 PM UTC, comment #9: > Committed error message fix. Leaving ticket open pending > decision whether to port feature to S2_3. patch for S2_3; contains both parts ... (file #14363)	Matthias Pfafferodt <syntron>
Tue 25 Oct 2011 08:29:04 PM UTC, comment #8: Committed error message fix. Leaving ticket open pending decision whether to port feature to S2_3.	Jacob Nevins <jtn>
Tue 25 Oct 2011 08:26:27 PM UTC, SVN revision 20329: Fix error message if trying "/remove" with game start. See gna bug #18641. (Browse SVN revision 20329)	Jacob Nevins <jtn>
Sun 23 Oct 2011 08:19:58 PM UTC, comment #6: > Is there any reason this whole patch wouldn't be safe to > backport to S2_3 as well? I suspect it'd be of more use to > Michal there. It should be save for 2.3 as well. Let's see if it can easily be ported ...	Matthias Pfafferodt <syntron>
Sat 22 Oct 2011 01:16:44 PM UTC, comment #5: The error message in this patch isn't quite right (it says things like "Command level basic needed to remove a player [...]" if the player has cmdlevel basic). Patch attached. Is there any reason this whole patch wouldn't be safe to backport to S2_3 as well? I suspect it'd be of more use to Michal there. (file #14237)	Jacob Nevins <jtn>
Sun 25 Sep 2011 04:16:18 PM UTC, SVN revision 20278: allow remove command for access level >= ADMIN in running games see gna bug #18641 (Browse SVN revision 20278)	Matthias Pfafferodt <syntron>
Sun 11 Sep 2011 09:20:42 PM UTC, comment #3: > Thank you for this, it will be most useful for maintaining low > memory consumption in my ltex game. Dead players still consume > memory, right? Correct; the memory is freed at the time the player data is destroyed.	Matthias Pfafferodt <syntron>
Sun 11 Sep 2011 07:17:33 PM UTC, comment #2: the command was disabled once a game was started in commit svn2366 (2000/09/06). At the moment server_remove_player() is used for running games without problems - so why do not use it here? Limited to access level >= Admin (file #14073)	Matthias Pfafferodt <syntron>
Sun 11 Sep 2011 02:18:33 PM UTC, comment #1: "Can a player have cities and units before the game starts?" They can if they are defined in a scenario. However, the limitations on the command are such that it seems pretty useless. IMHO it should either be liberated from the restriction or eliminated. I assume that the game start restriction was applied due to issues with diplomacy, AI confusion, or something similar?	David Lowe <doctorjlowe>
Sun 11 Sep 2011 09:49:14 AM UTC, original submission: I'm confused: > /help remove Command: remove - Fully remove player from game. Synopsis: remove <player-name> Level: ctrl Description: This completely removes a player from the game, including all cities and units etc. Use with care! > /remove testuser Players cannot be removed once the game has started. Can a player have cities and units before the game starts?	Michal Mazurek <akfaew>

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):


Comment:

Attached Files

file #14363: 0009-S2_3-allow-remove-command-for-access-level-ADMIN-in-.patch added by syntron (1kB - text/x-patch)

file #14237: trunk-remove-running-message.diff added by jtn (953B - text/x-patch - trunk r20324: fix error message)

file #14073: 0026-allow-remove-command-for-access-level-ADMIN-in-runni.patch added by syntron (997B - text/x-patch)

Depends on the following items: None found

Items that depend on this one: None found

Carbon-Copy List

-unavailable- added by jtn (Updated the item)

-unavailable- added by syntron (Updated the item)

-unavailable- added by doctorjlowe (Posted a comment)

-unavailable- added by akfaew (Submitted the item)

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

Please enter the title of George Orwell's famous dystopian book (it's a date):

Follow 19 latest changes.

Date	Changed By	Updated Field	Previous Value	Replaced By
Sat 19 Nov 2011 10:38:30 PM UTC	jtn	Open/Closed	Open	Closed
		Planned Release	2.4.0,2.3.2	2.3.2,2.4.0
Sat 19 Nov 2011 05:12:15 PM UTC	jtn	Open/Closed	Closed	Open
		Planned Release	2.4.0,2.3.1	2.4.0,2.3.2
Tue 08 Nov 2011 08:54:12 PM UTC	syntron	Status	Ready For Test	Fixed
		Open/Closed	Open	Closed
Mon 31 Oct 2011 06:39:37 PM UTC	syntron	Attached File	-	Added 0009-S2_3-allow-remove-command-for-access-level-ADMIN-in-.patch, #14363
		Status	Fixed	Ready For Test
		Planned Release	2.4.0	2.4.0,2.3.1
Sat 22 Oct 2011 01:16:43 PM UTC	jtn	Attached File	-	Added trunk-remove-running-message.diff, #14237
		Open/Closed	Closed	Open
Sun 25 Sep 2011 04:16:36 PM UTC	syntron	Status	Ready For Test	Fixed
		Assigned to	None	syntron
		Open/Closed	Open	Closed
Sun 11 Sep 2011 07:17:33 PM UTC	syntron	Attached File	-	Added 0026-allow-remove-command-for-access-level-ADMIN-in-runni.patch, #14073
		Category	None	general
		Status	None	Ready For Test
		Planned Release		2.4.0
		Summary	remove a player	allow remove command for access level >= ADMIN in running games

Show feedback again