bugBattle for Wesnoth - Bugs: bug #18686, Using really big images in...

 
 
Show feedback again

bug #18686: Using really big images in [message] can cause image doesn't fit on canvas errors to be thrown

Submitted by:  Steven Panek <espreon>
Submitted on:  Sun 18 Sep 2011 09:01:55 AM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group:  None of the others
Status: NonePrivacy: Public
Assigned to: Mark de Wever <mordante>Open/Closed: Open
Release: 1.9.9+svn (51225)Operating System: Sabayon Linux

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 23 Jan 2012 12:08:19 AM UTC, comment #6:

Another case of this scaling stuff is bug #17961.

Nils Kneuper <ivanovic>
Project Administrator
Sat 17 Dec 2011 07:16:06 PM UTC, comment #5:

The portrait in question is wider than 500 pixels, the original specifications
only allowed images to be 500 pixels wide. Fixing this part of the code has
been somewhat tricky in the past, since we're in a feature freeze now I prefer
to add the feature to allow wider images until 1.10 has been released.

Mark de Wever <mordante>
Project MemberIn charge of this item.
Mon 12 Dec 2011 12:17:18 AM UTC, comment #4:

Sadly, this isn't quite fixed yet.

As byspel, Nemesis's portrait in Bad Moon Rising causes this error. Note that I only get this in windowed mode. The resolutions should be the same from when I encountered the error in Mystery Campaign.

Error:

Image doesn't fit on canvas.

When reporting the bug please include the following error message :
Condition 'static_cast<int>(y) >= 0' failed at src/gui/auxiliary/canvas.cpp:1096 in function 'draw'. Extra development information: Image 'portraits/nemesis.png', y = -49.

To reproduce this, do the following:

1. Get BMR
2. Start episode three of BMR
3. :cl to 2_04_Legion, click through the dialog bands till you get to where Nemesis's band should be
4. Behold

Steven Panek <espreon>
Project Member
Sun 11 Dec 2011 04:58:30 PM UTC, comment #3:

I've tried the rithrandil portrait on various too-short resolutions. Both tiny netbook resolutions and cropped-1080p ones. It seems to be fixed.

Alexander van Gessel <ai0867>
Project Member
Sun 11 Dec 2011 03:56:51 PM UTC, SVN revision 52235:

Add test case for bug #17961 and bug #18686 to test scenario

(Browse SVN revision 52235)

Alexander van Gessel <ai0867>
Project Member
Sun 18 Sep 2011 09:07:22 AM UTC, comment #1:

Well, the portrait does exist... in TRoW. And Mystery Campaign loads up data from TRoW.

So yeah. The portrait is incredibly big too.

This error only occurs in windowed mode and I'm using 1366 x 713 while in windowed mode.

Steven Panek <espreon>
Project Member
Sun 18 Sep 2011 09:01:55 AM UTC, original submission:

When starting Mystery Campaign from the add-ons server, the following error is thrown and the campaign aborts:

The error message is :
Image doesn't fit on canvas.

When reporting the bug please include the following error message :
Condition 'static_cast<int>(y) >= 0' failed at /home/espreon/wesnoth/src/gui/auxiliary/canvas.cpp:1096 in function 'draw'. Extra development information: Image 'portraits/rithrandil.png', y = -44.

No such image exists in the campaign... and it probably doesn't exist in mainline either.

Steven Panek <espreon>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by ivanovic (Posted a comment)
  • -unavailable- added by ai0867 (Posted a comment)
  • -unavailable- added by mordante (Updated the item)
  • -unavailable- added by espreon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 29 Jan 2012 09:14:59 PM UTCshadowmasterStatusPostponed=>None
    Mon 23 Jan 2012 12:03:45 AM UTCivanovicStatusReady For Test=>Postponed
    Sat 10 Dec 2011 08:57:22 PM UTCmordanteStatusNone=>Ready For Test
    Sun 18 Sep 2011 09:09:58 AM UTCespreonSummaryUsing really big images in [message] can cause an image doesn\'t fit on canvas errors to be thrown=>Using really big images in [message] can cause image doesn't fit on canvas errors to be thrown
    Sun 18 Sep 2011 09:07:41 AM UTCespreonSummaryUsing really big images in [message] can cause an image doesn\'t fit on canvas error to be thrown=>Using really big images in [message] can cause an image doesn't fit on canvas errors to be thrown
    Sun 18 Sep 2011 09:07:22 AM UTCespreonSeverity2 - Minor=>3 - Normal
      SummarySpecifying a non-existent image in [message] causes an image doesn\'t fit on canvas error to be thrown=>Using really big images in [message] can cause an image doesn't fit on canvas error to be thrown
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup