bugBattle for Wesnoth - Bugs: bug #18746, No prestart event/settings for...

 
 
Show feedback again

bug #18746: No prestart event/settings for start of scenario save in MP campaign for non-host

Submitted by:  David Mikos <coffee>
Submitted on:  Tue 27 Sep 2011 08:08:59 AM UTC  
 
Category: BugSeverity: 2 - Minor
Priority: 1 - LaterItem Group: Multiplayer
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open
Release: 1.9.9Operating System: Linux (Ubuntu)

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 20 Dec 2011 12:59:49 AM UTC, comment #8:

Test results with A_Simple_MP_Campaign from the wesnoth UMC repository with trunk r52343:
I could reproduce a problem with [set_variable]'s rand=. For the remote client, it acts differently with the reloaded start-of-scenario save in comparison to during play and (apparently) the host who gets the same result as during the play which created the start-of-scenario save. The remote client got the wrong results from a turn 1 and new turn event (which are supposed to be synch'ed).
code example:
Results shown by :inspect differ between the clients.

Anonymissimus <anonymissimus>
Project Member
Mon 05 Dec 2011 04:12:22 PM UTC, comment #7:

Also, the savegame no longer works due to Khalifate removal, thats just one of the reasons why testcases have to be minimized. I don't want to read through tons of unknown wml to find out what's up.

Anonymissimus <anonymissimus>
Project Member
Mon 05 Dec 2011 04:08:11 PM UTC, comment #6:

I attempted reproducing; in my MP test campaign the prestart event and its changes to the gamestate went well no matter what as shown by :inspect.
Please attach a minimized testcase which demonstrates what you consider the bug. It is not realistic to expect that a bug which requires downloading a whole addon gets fixed.
Also note that everything prior to turn 1 events isn't listed as synchronized in the wiki, thus if you have [message][option] or something else which requires sending data to the other clients this of course doesn't work and is not a bug.

Anonymissimus <anonymissimus>
Project Member
Wed 26 Oct 2011 05:17:12 PM UTC, comment #5:

I was wrong about the recall list carryover part and even gold carryover seems to work correctly in trunk. I notice several other problems though.
Yet until we have a working mp campaign in mainline with the new syntax proper mp campaign support can't be added.
So more than fixing bugs introduced recently can't be done, and for this one even exists an easy workaround.

Anonymissimus <anonymissimus>
Project Member
Tue 25 Oct 2011 09:07:34 PM UTC, comment #4:

I'm marking this postponed and assigning to zaroth, since he was the one who had the project of unifying singleplayer/multiplayer syntax to that everything will be a mp campaign. So in case he comes back or someone else continues the bug can be found and assigned.
According to a bit testing of mine, not even the recall list carryover is handled like it should. Until the wml syntax change is done it doesn't make sense to attempt supporting MP campaigns.

Anonymissimus <anonymissimus>
Project Member
Thu 29 Sep 2011 07:56:06 AM UTC, comment #3:

Maybe I hadn't been too clear enough in my description for others to reproduce.

The attached file is a start of scenario save from my multiplayer campaign called The Great Quest. The bug occurs with all MP campaigns (see World Conquest, etc.) for the start of scenario save for scenario 2,3,4,etc. only when playing online and reloading from it, and then only on non-host computers (causing an out-of-sync).

The bug is that the prestart/start or gold/AI settings (side settings) are not executed on the computers other than the host computer. The attached file is such a save and you can reproduce easily by loading in multiplayer and then checking on host to see the problem.

This can be worked around by adding a turn 1 event that says to modify start gold from default, AI behaviour from default, etc. and using no prestart/start events (you seemingly can rely on variables from previous scenarios).

David Mikos <coffee>
Project Member
Wed 28 Sep 2011 05:49:37 PM UTC, comment #2:

Also, it would be nice to name the addon precisely or attach it so someone may reproduce.

Anonymissimus <anonymissimus>
Project Member
Wed 28 Sep 2011 05:44:27 PM UTC, comment #1:

Why should adding it to a turn 1 event possibly be more work than adding it to a prestart event ?
Other than that, mp campaigns seem to be rather inherently broken since long, since unfortunately the GSoC project which was supposed to fix this ceased, and this probably counts as a FR anyway.

Anonymissimus <anonymissimus>
Project Member
Tue 27 Sep 2011 08:08:59 AM UTC, original submission:

When reloading the start of scenario save that is created automatically by Wesnoth (and can be switched off by WML I know), the prestart events (or gold/turn/etc. settings) do not run on non-host computers.

See the example file below. Works on host - adds sand terrain top-right, gold/turn/etc. settings - but does none of these things for non-host.

To add these things to a turn 1 event would mean a lot of work for setting gold for each team, etc. It would be nice if this could be fixed :)

David Mikos <coffee>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #14171:  3p_-_The_Great_Quest_2S.gz added by coffee (120kB - application/x-gzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by anonymissimus (Posted a comment)
  • -unavailable- added by coffee (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 29 Jan 2012 10:55:34 PM UTCshadowmasterAssigned tozaroth=>None
    Tue 20 Dec 2011 07:57:05 PM UTCanonymissimusStatusNeed Info=>None
    Mon 05 Dec 2011 04:08:11 PM UTCanonymissimusStatusPostponed=>Need Info
    Wed 26 Oct 2011 05:19:05 PM UTCanonymissimusSeverity3 - Normal=>2 - Minor
      Priority5 - Normal=>1 - Later
    Tue 25 Oct 2011 09:07:34 PM UTCanonymissimusStatusNone=>Postponed
      Assigned toNone=>zaroth
    Tue 27 Sep 2011 08:08:59 AM UTCcoffeeAttached File-=>Added 3p_-_The_Great_Quest_2S.gz, #14171
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup