Freeciv - Bugs: bug #19064, g_object_ref: assertion... [Gna!]

Freeciv - Bugs: bug #19064, g_object_ref: assertion...

Group

Main
- Main
- View Members
- Search
Homepage
Download
Docs
- Browse
- Submit
- Edit
- Digest
- Export
- Search
Mailing Lists
Source Code
- Use Subversion
- Browse Sources Repository
Bugs
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search
Tasks
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search
Patches
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search

Show feedback again

bug #19064: g_object_ref: assertion `object->ref_count > 0' failed

Submitted by:	Jacob Nevins <jtn>
Submitted on:	Sun 27 Nov 2011 09:22:23 PM UTC

Category:	client-gtk-2.0	Severity:	3 - Normal
Priority:	5 - Normal	Status:	None
Assigned to:	None	Open/Closed:	Open
Release:	S2_3 r20613	Operating System:	GNU/Linux
Planned Release:

Add a New Comment (Rich Markup):

You are not logged in

Please log in, so followups can be emailed to you.

Mon 28 Nov 2011 12:22:34 AM UTC, comment #3: Well, I commented out the g_object_unref() and connected to that server a few times and didn't get warnings, but I'm not sure that proves anything; I could just be quietly leaking resources, and when I saw this behaviour on this server once before, it didn't seem reproducible (although it seems so now). Attached a screenshot of the featured text in question, partly to give some idea about reproducing and partly because it's cute. ;) (file #14610)	Jacob Nevins <jtn>
Mon 28 Nov 2011 12:11:06 AM UTC, comment #2: I don't have a complete picture of what's going on yet, but I'm a little dubious about this code in gui-gtk-2.0/chatline.c:apply_text_tag(): GtkTextBuffer buf; / ... / case TTT_COLOR: { / We have to make a new tag every time. / GtkTextTag tag = NULL; /* ... / tag = gtk_text_buffer_create_tag(buf, NULL, / ... /); / ... / gtk_text_buffer_apply_tag(buf, tag, / ... /); g_object_unref(G_OBJECT(tag)); / Bad? / } Looking at the gtk_text_buffer_create_tag() docs, I think* that the ownership of the created tag is passed to a structure inside 'buf', so the caller doesn't have to free it. The annotation "transfer none" apparently means "Don't free data after the code is done", which I think may corroborate my argument. The same applies to case TTT_LINK. This server uses loads of colours, though, so I'm not sure why we're not seeing loads of these warnings. Perhaps the reference count only drops below zero in unusual circumstances. Or perhaps this possible thing I've found has nothing to do with these warnings.	Jacob Nevins <jtn>
Sun 27 Nov 2011 10:26:33 PM UTC, comment #1: Should have said, I'm connected as a global observer.	Jacob Nevins <jtn>
Sun 27 Nov 2011 09:22:23 PM UTC, original submission: Getting some Gtk warnings from the client (S2_3 r20613, circa 2.3.1) on initial connection to the server "freeciv-debian.ns0.it" (which can be found on the metaserver at the moment). This server sends some funky featured text on connect with a colour ASCII-art picture of a soldier; I suspect this is implicated, but I haven't investigated further. The warnings from a normal run: (freeciv-gtk2:5626): GLib-GObject-CRITICAL : g_object_ref: assertion `object->ref_count > 0' failed (freeciv-gtk2:5626): GLib-GObject-CRITICAL : g_object_unref: assertion `object->ref_count > 0' failed (freeciv-gtk2:5626): GLib-GObject-CRITICAL *: g_object_unref: assertion `object->ref_count > 0' failed With "-d 3 -l file -- --g-fatal-warnings", it dies at the first of these, with the following backtrace: #0 0x00007f95448caa75 in __GI_raise (sig=<value optimised out>) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64 pid = <value optimised out> selftid = <value optimised out> #1 0x00007f95448ce5c0 in *__GI_abort () at abort.c:92 act = {__sigaction_handler = {sa_handler = 0, sa_sigaction = 0}, sa_mask = {__val = {33844864, 2, 140279080377920, 2, 171540480, 140279076739848, 140279153072528, 140279085612640, 4294967295, 2, 5, 2998376, 0, 140734672850160, 140279085612640, 140279082610688}}, sa_flags = 1224238993, sa_restorer = 0x7fff00000005} sigs = {__val = {32, 0 <repeats 15 times>}} #2 0x00007f9544e8033a in g_logv () from /lib/libglib-2.0.so.0 No symbol table info available. #3 0x00007f9544e803d3 in g_log () from /lib/libglib-2.0.so.0 No symbol table info available. #4 0x00007f954573573a in g_object_ref () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #5 0x00007f95474b1707 in ?? () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #6 0x00007f95474b1f0f in ?? () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #7 0x00007f95474d348c in gtk_text_tag_table_remove () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #8 0x00007f95474d1512 in ?? () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #9 0x00007f95457355a4 in g_object_unref () from /usr/lib/libgobject-2.0.so.0 No symbol table info available. #10 0x0000000000496bf1 in apply_text_tag (astring=0x7fff582ed760 "", tags=<value optimised out>, conn_id=<value optimised out>) at chatline.c:829 tag = 0xa38b480 foreground = {pixel = 1536, red = 0, green = 0, blue = 0} background = {pixel = 1, red = 65535, green = 65535, blue = 65535} start = {dummy1 = 0x2badc00, dummy2 = 0xa3a9000, dummy3 = -1, dummy4 = 0, dummy5 = 724, dummy6 = -1, dummy7 = -829544620, dummy8 = -1052114181, dummy9 = 0x2bb07a0, dummy10 = 0xa37bf60, dummy11 = -1, dummy12 = 0, dummy13 = -1650614882, dummy14 = 0xa381f60} stop = {dummy1 = 0x2badc00, dummy2 = 0xa3a9000, dummy3 = -1, dummy4 = 0, dummy5 = 724, dummy6 = -1, dummy7 = -829544620, dummy8 = -1052114181, dummy9 = 0x2bb07a0, dummy10 = 0xa37bf60, dummy11 = -1, dummy12 = 0, dummy13 = 1158755856, dummy14 = 0x565425} initalized = true #11 real_output_window_append (astring=0x7fff582ed760 "", tags=<value optimised out>, conn_id=<value optimised out>) at chatline.c:903 ptag_iter = <value optimised out> ptag = <value optimised out> buf = 0x20cd1b0 iter = {dummy1 = 0x2badc00, dummy2 = 0xa3a9000, dummy3 = 0, dummy4 = 0, dummy5 = 724, dummy6 = -1, dummy7 = -829544620, dummy8 = -1052114183, dummy9 = 0x0, dummy10 = 0x0, dummy11 = -10000, dummy12 = -10000, dummy13 = 175, dummy14 = 0x7f954574d4f8} mark = 0x5615d80 text_start_offset = 724 __FUNCTION__ = "real_output_window_append" #12 0x00000000004211f3 in handle_event (featured_text=<value optimised out>, ptile=<value optimised out>, event=E_SETTING, conn_id=<value optimised out>) at climisc.c:1021 plain_text = "\000\343\067\n\000\000\000\000\000\343\067\n\000\000\000\000\000\020\000\000\000\000\000\000\366\350\217D\225\177\000\000\006\b\000\000\000\000\000\000\001`\357\000\000\000\000\000\001\000\000\000\000\000\000\000\244\201\000\000\350\003\000\000\350\003\000\000\000\000\000\000\360\327.X\377\177\000\000 \225\230\000\000\000\000\000\340\330.X\377\177\000\000\001\000\000\000\000\000\000\000\000\334.X\377\177\000\000\377\001\000\000\000\000\000\000\377\343Z\000\000\000\000\000 \225\230\000\000\000\000\000`G\231D\225\177\000\000\001\200\255\373\000\000\000\000 \225\230\000\000\000\000\000 \225\230\000\000\000\000\000 \225\230\000\000\000\000\000 \225\230\000\000\000\000\000\065\225\230\000\000\000\000\000\037\227\230\000\000\000\000\000 \225\230\000\000\000\000\000\037\227\230", '\000' <repeats 45 times>"\350, \003\000\000\004\000\000\000\000\001\000\000\000\000\000\000 \000\000\000\000\000\000\000\016\000\000\000\000\000\000\000"... tags = 0x208c780 where = <value optimised out> fallback_needed = false shown = false __FUNCTION__ = "handle_event" #13 0x0000000000449834 in client_handle_packet (type=<value optimised out>, packet=0x0) at packhand_gen.c:81 No locals. #14 0x000000000041eb2e in client_packet_input (packet=<value optimised out>, type=25) at client_main.c:573 __FUNCTION__ = "client_packet_input" #15 0x00000000004245b5 in input_from_server (fd=<value optimised out>) at clinet.c:419 result = true packet = 0x0 type = PACKET_CHAT_MSG nb = <value optimised out> __FUNCTION__ = "input_from_server" #16 0x00007f9547059d3f in ?? () from /usr/lib/libgdk-x11-2.0.so.0 No symbol table info available. #17 0x00007f9544e758c2 in g_main_context_dispatch () from /lib/libglib-2.0.so.0 No symbol table info available. #18 0x00007f9544e79748 in ?? () from /lib/libglib-2.0.so.0 No symbol table info available. #19 0x00007f9544e79c55 in g_main_loop_run () from /lib/libglib-2.0.so.0 No symbol table info available. #20 0x00007f954741cbc7 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0 No symbol table info available. #21 0x000000000041700f in ui_main (argc=1, argv=0x7fff582ee3f8) at gui_main.c:1667 home = <value optimised out> sig = <value optimised out> __FUNCTION__ = "ui_main" #22 0x000000000041efce in client_main (argc=<value optimised out>, argv=0x7fff582ee3f8) at client_main.c:516 i = 7 loglevel = LOG_VERBOSE ui_options = <value optimised out> ui_separator = 192 option = <value optimised out> user_tileset = false fatal_assertions = -1 __FUNCTION__ = "client_main" #23 0x00007f95448b5c4d in __libc_start_main (main=<value optimised out>, argc=<value optimised out>, ubp_av=<value optimised out>, init=<value optimised out>, fini=<value optimised out>, rtld_fini=<value optimised out>, stack_end=0x7fff582ee3e8) at libc-start.c:226 result = <value optimised out> unwind_buf = {cancel_jmp_buf = {{jmp_buf = {0, -5493296897614316628, 4272608, 140734672856048, 0, 0, 5493639265993718700, 5542077936789715884}, mask_was_saved = 0}}, priv = {pad = { 0x0, 0x0, 0x585680, 0x7fff582ee3f8}, data = {prev = 0x0, cleanup = 0x0, canceltype = 5789312}}} not_first_call = <value optimised out> #24 0x0000000000413209 in _start () No symbol table info available. Last few entries from the log: ... 3: in get_packet_from_connection() [packets.c::463]: got packet type=(PACKET_CHAT_MSG)25 len=69 from server 3: in receive_packet_chat_msg_100() [packets_gen.c::6942]: packet_chat_msg_100: got info about () 3: in receive_packet_chat_msg_100() [packets_gen.c::6957]: got field 'message' 3: in audio_play_tag() [audio.c::281]: No sound file for tag e_setting (file (null)) 3: in audio_play_sound() [audio.c::306]: Neither of tags e_setting or (null) found 3: in get_packet_from_connection() [packets.c::463]: got packet type=(PACKET_CHAT_MSG)25 len=69 from server 3: in receive_packet_chat_msg_100() [packets_gen.c::6942]: packet_chat_msg_100: got info about () 3: in receive_packet_chat_msg_100() [packets_gen.c::6957]: got field 'message' 3: in audio_play_tag() [audio.c::281]: No sound file for tag e_setting (file (null)) 3: in audio_play_sound() [audio.c::306]: Neither of tags e_setting or (null) found 3: in get_packet_from_connection() [packets.c::463]: got packet type=(PACKET_CHAT_MSG)25 len=38 from server 3: in receive_packet_chat_msg_100() [packets_gen.c::6942]: packet_chat_msg_100: got info about () 3: in receive_packet_chat_msg_100() [packets_gen.c::6957]: got field 'message'	Jacob Nevins <jtn>

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):


Comment:

Attached Files

file #14610: freeciv-debian.ns0.it.png added by jtn (170kB - image/png - screenshot of featured text from freeciv-debian.ns0.it)

Depends on the following items: None found

Items that depend on this one: None found

Carbon-Copy List

-unavailable- added by jtn (Submitted the item)

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

Please enter the title of George Orwell's famous dystopian book (it's a date):

Follows 1 latest change.

Date	Changed By	Updated Field	Previous Value	=>	Replaced By
Mon 28 Nov 2011 12:22:34 AM UTC	jtn	Attached File	-		Added freeciv-debian.ns0.it.png, #14610

Show feedback again