bugFreeciv - Bugs: bug #19088, Put more Windows...

 
 
Show feedback again

bug #19088: Put more Windows installer/packaging material under version control

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Thu 01 Dec 2011 02:55:28 AM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: Microsoft Windows
Planned Release: 2.3.3, 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 09 Jul 2012 01:44:57 AM UTC, SVN revision 21475:

Ported Windows Installer build scripts from S2_3

See gna bug #19088

(Browse SVN revision 21475)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 09 Jul 2012 01:44:47 AM UTC, SVN revision 21474:

Ported Windows Installer build scripts from S2_3

See gna bug #19088

(Browse SVN revision 21474)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 07 Jul 2012 09:14:27 PM UTC, comment #8:

> Build failed due to missing makensis, so instructions to install
> it should be added


This worked the next time I tried to build. Maybe it requires relaunching MinGW after development environment installation?

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 07 Jul 2012 09:10:07 PM UTC, comment #7:

> and presumably TRUNK


Now also tested, and found working.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 06 Jul 2012 04:05:40 PM UTC, comment #6:

Material for S2_4 (and presumably TRUNK - I'll commit there too).

- Contains patch #3365
- libcurl and recursive dependencies added

(file #15990)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 03 Jul 2012 02:18:24 PM UTC, comment #5:

I just had a bit of Windows time, so I tried to build installers following instructions on top of this Makefile. Build failed due to missing makensis, so instructions to install it should be added. (I downloaded some nsis package, but command makensis was still not available - I was able to build working installer with that gui, though)

On a related note, maybe we with limited Windows access can cross-build these on Linux:
http://mohanjith.net/blog/2007/08/makensis-on-linux.html

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 15 Apr 2012 08:16:50 PM UTC, SVN revision 21166:

Put Windows installer material under version control.

See gna bug #19088.

(Browse SVN revision 21166)

Christian Prochaska <cproc>
Project Administrator
Sun 08 Apr 2012 01:18:40 AM UTC, comment #3:

The attached patch adds the installer-relevant files to the repository, including a Makefile which automates the building and packaging on Windows :-)

(file #15534)

Christian Prochaska <cproc>
Project Administrator
Thu 01 Dec 2011 09:41:26 AM UTC, comment #2:

The important scripts are the 'create-freeciv-<version>-nsi.sh' ones. They are used to create the actual NSIS installer scripts (Freeciv-<version>.nsi) based on the content to be installed (this content can currently be found in the 'Freeciv-<version>.7z' files on download.gna.org). The latest versions of the scripts are attached to this ticket and the corresponding content archives are now available at http://download.gna.org/freeciv/packages/windows/installer-scripts/

(file #14626, file #14627, file #14628, file #14629)

Christian Prochaska <cproc>
Project Administrator
Thu 01 Dec 2011 06:56:56 AM UTC, comment #1:

Yes, inclusion of those scripts is required by GPL for the very reason that others could build binaries. To be pedantic, producing binaries from tweaked sources without then releasing those modified sources would be violation of GPL too, or at least they should be stored in safe place in case someone requests them.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 01 Dec 2011 02:55:28 AM UTC, original submission:

The description of packaging for Windows refers to Nullsoft installer scripts, or scripts that generate those scripts, that live outside of version control. Some of those scripts can be found on download.gna.org.

It would be nice if some of this material could be moved under version control. I'm not suggesting any attempt to actually fully automate all the steps of the Windows package build, but having the latest material visible in version control might allow more developers to help with Windows packaging issues. A particular project I think this would help with is making language selection more slick (bug #19087).

If this were done, routine procedures like changing the version number could actually be done as part of the tarball release process by autoconf, taking a .in file and dumping out preprocessed installer script material for inclusion in the tarball, where the Windows packager could pick it up. I can help with this if it looks workable.

A possible workflow glitch is that the packager will probably only discover a required tweak to this material after the release manager has dropped the tag and built the tarball, so the material used won't be identical to what's in the tarball. I guess we'll just have to live with that

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #15990:  WinInstaller.tar.bz2 added by cazfi (5kB - application/x-bzip)
file #15534:  win32_installer-S2_3.diff added by cproc (24kB - plain/text)
file #14626:  create-freeciv-2.3.1-gtk2-nsi.sh added by cproc (8kB - application/octet-stream)
file #14627:  Freeciv-2.3.1-gtk2.nsi added by cproc (183kB - application/octet-stream)
file #14628:  create-freeciv-2.3.1-sdl-nsi.sh added by cproc (9kB - application/octet-stream)
file #14629:  Freeciv-2.3.1-sdl.nsi added by cproc (175kB - application/octet-stream)

 

Depends on the following items: None found

Digest:
   bug dependencies, task dependencies, patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by cproc (Updated the item)
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 13 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 09 Jul 2012 01:45:08 AM UTCcazfiStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Fri 06 Jul 2012 04:06:43 PM UTCcazfiStatusNone=>Ready For Test
      Assigned tocproc=>cazfi
    Fri 06 Jul 2012 04:05:40 PM UTCcazfiAttached File-=>Added WinInstaller.tar.bz2, #15990
    Mon 02 Jul 2012 02:54:24 PM UTCcazfiPlanned Release=>2.3.3, 2.4.0, 2.5.0
    Sun 08 Apr 2012 01:18:40 AM UTCcprocAttached File-=>Added win32_installer-S2_3.diff, #15534
      Assigned toNone=>cproc
    Thu 01 Dec 2011 09:41:26 AM UTCcprocAttached File-=>Added create-freeciv-2.3.1-gtk2-nsi.sh, #14626
      Attached File-=>Added Freeciv-2.3.1-gtk2.nsi, #14627
      Attached File-=>Added create-freeciv-2.3.1-sdl-nsi.sh, #14628
      Attached File-=>Added Freeciv-2.3.1-sdl.nsi, #14629
    Thu 01 Dec 2011 02:55:43 AM UTCjtnDependencies-=>bugs #19087 is dependent
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup