bugFreeciv - Bugs: bug #19168, mapimg automatic save dumps images...

 
 
Show feedback again

bug #19168: mapimg automatic save dumps images in current directory

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sun 11 Dec 2011 12:58:26 AM UTC  
 
Category: generalSeverity: 5 - Blocker
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: Any
Planned Release: 2.4.0,2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 13 Mar 2013 04:47:28 AM UTC, SVN revision 22509:

Save mapimgs produced by server to the autosave directory.

Requested by Jacob Nevins

See bug #19168

(Browse SVN revision 22509)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 13 Mar 2013 04:47:21 AM UTC, SVN revision 22508:

Save mapimgs produced by server to the autosave directory.

Requested by Jacob Nevins

See bug #19168

(Browse SVN revision 22508)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 08 Mar 2013 03:56:53 AM UTC, comment #5:

- Updated against latest svn

(file #17406)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 28 Feb 2013 06:35:35 AM UTC, comment #4:

- Mapimgs created with manual "mapimg create" go to autosave directory to be consistent with how manual saves go there too. "mapimg colortest" still saves to current directory as it's not about state of the current game.

(file #17375)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 21 Feb 2013 08:33:13 AM UTC, comment #3:

Untested patch

- mapimgs with absolute paths in their name always go to that directory

Otherwise:
- mapimgs automatically created on turn change on server side go to autosave directory
- mapimgs created by explicit server commands go to current directory
- mapimgs created client side go to current directory

(file #17302)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 17 Jun 2012 04:41:59 PM UTC, comment #2:

File #11108 attached to bug #16887 gives a clue as to Matthias' original plans here.

Jacob Nevins <jtn>
Project Administrator
Wed 23 May 2012 11:28:36 PM UTC, comment #1:

> I think saving to the same location as autosave files would be
> entirely sufficient, and should be easy enough.


This is also what freeciv.net expects. (Too bad current implementation there is such that it's not usable to main freeciv)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 11 Dec 2011 12:58:26 AM UTC, original submission:

Follow-on from patch #1391 comment 24:

The images saved automatically after using the "mapimg" server command are currently saved in the working directory.

We could make the image directory seperately configurable, but personally I think saving to the same location as autosave files would be entirely sufficient, and should be easy enough.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17406:  MapimgPath-3.patch added by cazfi (7kB - text/x-diff)
file #17375:  MapimgPath-2.patch added by cazfi (7kB - text/x-diff)
file #17302:  MapimgPath.patch added by cazfi (6kB - text/x-diff)

 

Depends on the following items: None found

Digest:
   task dependencies, patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 13 Mar 2013 04:47:41 AM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Fri 08 Mar 2013 03:56:53 AM UTCcazfiAttached File-=>Added MapimgPath-3.patch, #17406
    Thu 28 Feb 2013 06:35:35 AM UTCcazfiAttached File-=>Added MapimgPath-2.patch, #17375
    Thu 21 Feb 2013 08:33:13 AM UTCcazfiAttached File-=>Added MapimgPath.patch, #17302
      StatusNone=>Ready For Test
    Sat 09 Feb 2013 09:46:40 PM UTCcazfiSeverity3 - Normal=>5 - Blocker
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup