bugBattle for Wesnoth - Bugs: bug #19225, [object] reevaluates variables at...

 
 
Show feedback again

bug #19225: [object] reevaluates variables at the time the effect is applied, not when the event where it appears runs

Submitted by:  Anonymissimus <anonymissimus>
Submitted on:  Thu 29 Dec 2011 11:10:42 PM UTC  
 
Category: BugSeverity: 5 - Blocker
Priority: 5 - NormalItem Group:  None of the others
Status: FixedPrivacy: Public
Assigned to: Anonymissimus <anonymissimus>Open/Closed: Closed
Release: 1.9.13, trunk r52422Operating System: all

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 02 Jan 2012 10:25:53 PM UTC, comment #3:

testcode was:

Anonymissimus <anonymissimus>
Project MemberIn charge of this item.
Mon 02 Jan 2012 10:12:02 PM UTC, SVN revision 52448:

Revert revisions of mine: 51930, 51947

These were the variable substitution delaying in the [object] code. It is
no longer needed due to the workaround [object]delayed_...=yes|no.
Removes repeated wml parsing. Reverts behavior to mostly what was in 1.8
If ABILITY_TELEPORT is added by an [object], or [object][effect][filter]
contains $this_unit, delayed_...=yes is required for the modifications
to work as expected.
However, if the same object wants to get variables substituted and
add ABILITY_TELEPORT to a unit, the code would have worked in 1.8
but doesn't in 1.9.
(bug #18893, bug #19225)

(Browse SVN revision 52448)

Anonymissimus <anonymissimus>
Project MemberIn charge of this item.
Thu 29 Dec 2011 11:27:40 PM UTC, SVN revision 52425:

introduce [object]delayed_variable_substitution=yes|no (def no) (bug #18893, bug #19225)

This isn't pretty since we are repeatedly parsing wml in the common case...

(Browse SVN revision 52425)

Anonymissimus <anonymissimus>
Project MemberIn charge of this item.
Thu 29 Dec 2011 11:10:42 PM UTC, original submission:

bug report for the problem described here: http://forums.wesnoth.org/viewtopic.php?f=21&t=35768&p=517161#p517161

Anonymissimus <anonymissimus>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by anonymissimus (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 08 Jan 2012 08:58:21 PM UTCanonymissimusOpen/ClosedOpen=>Closed
    Mon 02 Jan 2012 10:13:08 PM UTCanonymissimusStatusNone=>Fixed
    Sat 31 Dec 2011 03:13:43 PM UTCanonymissimusSeverity3 - Normal=>5 - Blocker
    Thu 29 Dec 2011 11:11:18 PM UTCanonymissimusSummary[object] reevaluates variables at the time it is applied, not when the event where it appears runs=>[object] reevaluates variables at the time the effect is applied, not when the event where it appears runs
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup