bugMyPaint - Bugs: bug #19460, Brush selector popup should be...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #19460: Brush selector popup should be 'toggleable'

Submitted by:  David Gowers <ion9>
Submitted on:  Thu 16 Feb 2012 07:13:30 AM UTC  
 
Severity: 3 - NormalPriority: 5 - Normal
Status: Ready For TestPrivacy: Public
Assigned to: Andrew Chadwick <achadwick>Open/Closed: Open
Release: Planned Release: None
Operating System: 

Mon 14 Jan 2013 02:26:45 PM UTC, comment #3:

https://gitorious.org/mypaint/mypaint/commit/f267bbaa2a5e1875d2dc29ff74b460b7520a1708

Cursor-out now closes the dialog without making a brush selection, with some pixels of grace for resizing purposes and to be tolerant of sloppy positioning.

I consider this bug fully addressed; please test, and let me know what you think.

Andrew Chadwick <achadwick>
Project AdministratorIn charge of this item.
Sun 13 Jan 2013 08:09:50 PM UTC, comment #2:

Yeah, I'd intended it to do this when I wrote it, but never got around to fixing it. The brush chooser is actually intended to work somewhat like the colour popups, so bouncing on the "B" key should do something; dismissing the window works for me.

I've pushed an initial attempt at this to https://gitorious.org/mypaint/mypaint/commit/d00fe94a063fd499cce221f85da466f43f9d1f16

Possibly it should dismiss when you move outside too, like the V and C colour popups? After all, it presents under the mouse each time, and it's reasonably big.

Left and right bindings for this window would be tricky to get right. For one thing, they'd be useful navigation in the grid of brushes too (there are other reasons related to differences in how different sorts of keys are handled). For now, let's stick with the mouse to keep it simple.

Andrew Chadwick <achadwick>
Project AdministratorIn charge of this item.
Mon 26 Nov 2012 03:00:49 PM UTC, comment #1:

Confirmed in git master.

Jon Nordby <jonnor>
Project Administrator
Thu 16 Feb 2012 07:13:30 AM UTC, original submission:

Currently, in contrast to the Brush Editor, if you hit the brush selector shortcut key to pop up the dialog, then decide you don't want to change brush, you must hit Escape, Alt-C(ancel) or click the Cancel button, in order to dismiss the popup.

IMO the ideal behaviour is to match the brush editor -- press the same key to dismiss it.

Perhaps slightly off the topic of this bug report: being able to switch to next/previous group using Left and Right arrows would also help.

David Gowers <ion9>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by achadwick (Posted a comment)
  • -unavailable- added by jonnor (Posted a comment)
  • -unavailable- added by ion9 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 14 Jan 2013 02:26:45 PM UTCachadwickStatusIn Progress=>Ready For Test
    Sun 13 Jan 2013 08:09:50 PM UTCachadwickStatusConfirmed=>In Progress
      Assigned toNone=>achadwick
    Mon 26 Nov 2012 03:00:49 PM UTCjonnorStatusNone=>Confirmed
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup