bugFreeciv - Bugs: bug #19474, max_players cleanup

 
 
Show feedback again

bug #19474: max_players cleanup

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sun 19 Feb 2012 06:17:52 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 31 Mar 2013 12:19:20 AM UTC, comment #3:

> I don't know yet how many separate bugs that makes.


Turning this to meta ticket.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 31 Mar 2013 12:05:42 AM UTC, comment #2:

Further testing in TRUNK with midgame player /create (new feature in S2_4, which is likely to be affected too)

1. Start singleplayer game with default maxplayers: 126
2. Save
3. Inspect savegame to see that maxplayers setting is 126 there
4. Load
5. "/explain maxplayers" to see it's 1
6. "/create midgamer" with no errors
7. "/explain maxplayers" to see it's still 1
8. "/list" to see that new player really exist
9. Save with new name
10. Load -> "1: Savegame: error restoring 'maxplayers' . (Number of players (5) is higher than requested value (1). Keeping old value.)"

I don't know yet how many separate bugs that makes. Good news is that there's bugs countering each other (midgame player creation is possible despite maxplayers getting to set to value that should prevent it)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 30 Mar 2012 10:06:29 PM UTC, comment #1:

Looking the max_players handling I find out that in many cases it's not really used for limiting number of players as advertised. Instead, when ever number of players hit max_players limit, limit is just increased.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 19 Feb 2012 06:17:52 PM UTC, original submission:

From still unresolved RT ticket #40226:

Subject: game.info.max_players dual meaning
Date: Fri, 2 May 2008 21:42:20 +0300
To: -unavailable-
From: "Marko Lindqvist" <cazfi74@gmail.com>

Noticed from metaserver that maxplayers setting in running game is
not what I initially set it. It seems that game.info.max_players is
used as both maxplayers setting, and storing number of players there
has been in the game at max.

---

This seems to be more serious problem nowadays. I tested single player (less players than default aifill of 5) game with saving and loading. After second save/load-cycle game complained that maxplayers setting (1) is less than current number of players (5). Savegame file itself correctly has only 1 player, so I assume number of 5 being what server had before starting game loading, and order of loading goes so that maxplayers setting is checked before setting number of players to one from savegame.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Digest:
   bug dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 18 Apr 2013 07:53:48 PM UTCcazfiOpen/ClosedOpen=>Closed
    Thu 18 Apr 2013 07:53:47 PM UTCcazfiCategoryNone=>general
      StatusNone=>Fixed
      Assigned toNone=>cazfi
    Mon 01 Apr 2013 09:02:28 PM UTCcazfiDependencies-=>Depends on bugs #20693
    Sun 31 Mar 2013 12:41:06 AM UTCcazfiDependencies-=>Depends on bugs #20690
    Sun 31 Mar 2013 12:40:53 AM UTCcazfiDependencies-=>Depends on bugs #20689
    Sun 31 Mar 2013 12:19:20 AM UTCcazfiSummarymax_players dual meaning=>max_players cleanup
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup