bugBattle for Wesnoth - Bugs: bug #19513, Incorect string in hotkeys dialog

 
 
Show feedback again

bug #19513: Incorect string in hotkeys dialog

Submitted by:  Fallen Phoenix <fphoenix>
Submitted on:  Thu 01 Mar 2012 02:19:48 AM UTC  
 
Category: BugSeverity: 2 - Minor
Priority: 5 - NormalItem Group: Editor
Status: FixedPrivacy: Public
Assigned to: Fabian Müller <fendrin>Open/Closed: Closed
Release: 1.10.1Operating System: WinXP/Ubuntu

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 14 Jan 2014 05:45:27 AM UTC, comment #2:

This bug no longer seems reproducible with 1.11.8 and 1.11.8+dev, presumably due to much of the editor and hotkey code being rewritten or heavily modified throughout the 1.11.x series.

There still appear to exist hotkey entries for "Auto-update Terrain Transitions: No" and "Auto-update Terrain Transitions: Partial", but they are hidden from the hotkeys menu.

Ignacio R. Morelle <shadowmaster>
Project Administrator
Thu 10 May 2012 08:38:29 PM UTC, comment #1:

For anyone who might attempt to fix this:

The problem with this feature is how it was conceived in the first place; there's code in the editor changing the title of the Auto-update Terrain Transitions option in the hotkeys table (<anonymous>::hotkey_list_ in src/hotkeys.cpp) every time the option is toggled or displayed.

The label used for a specific menu entry is currently (as far as I know) always the same as the label that will be used in the Hotkeys dialog entry because of the theme UI design (i.e. most menu options have a hotkeys table entry), which did not account for changing labels like this.

Ignacio R. Morelle <shadowmaster>
Project Administrator
Thu 01 Mar 2012 02:19:48 AM UTC, original submission:

As I understand, hotkey dialog must use "Auto-update Terrain Transitions" string from wesnoth-lib domain, and it's work properly at first. But when I open map-menu and then hotkeys, it changed to string with parameter, from wesnoth-editor domain.

Fallen Phoenix <fphoenix>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #15247:  editor-hotkey-issue.jpg added by fphoenix (439kB - image/jpeg)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Posted a comment)
  • -unavailable- added by fphoenix (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 24 Feb 2014 01:08:26 AM UTCshadowmasterStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue 14 Jan 2014 05:45:27 AM UTCshadowmasterStatusNone=>Ready For Test
      Assigned toNone=>fendrin
    Thu 01 Mar 2012 02:19:48 AM UTCfphoenixAttached File-=>Added editor-hotkey-issue.jpg, #15247
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup