bugFreeciv - Bugs: bug #19526, Guest fallback on database error...

 
 
Show feedback again

bug #19526: Guest fallback on database error doesn't work

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Tue 06 Mar 2012 12:27:52 AM UTC  
 
Category: generalSeverity: 2 - Minor
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: S2_3, S2_4Operating System: Any
Planned Release: 2.6.0, 3.0.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 17 Apr 2016 03:56:18 AM UTC, SVN revision 32424:

Added new chat package type to be used for some chats related to login procedure
on auth-enabled server. Unlike normal chat packet, this one is accepted by the client
in the early phase.

Reported by Jacob Nevins

See bug #19526

(Browse SVN revision 32424)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 17 Apr 2016 03:56:11 AM UTC, SVN revision 32423:

Added new chat package type to be used for some chats related to login procedure
on auth-enabled server. Unlike normal chat packet, this one is accepted by the client
in the early phase.

Reported by Jacob Nevins

See bug #19526

(Browse SVN revision 32423)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 10 Apr 2016 07:25:22 PM UTC, comment #2:

> Either the server shouldn't send the chat message, or the
> client should be more relaxed about receiving early chat
> messages (client_packet_input()), or possibly both.


Attached (untested) fix takes option 4; add a new packet type that that client accepts early.
The reason I didn't want open it up for all chat messages is that there might be game related chat messages coming to all connections that we shouldn't really receive/handle before we are all set up for that game.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 17 Jun 2012 06:56:50 PM UTC, comment #1:

Probably the same situation applies to "Warning: the guest name '%s' has been taken, renaming to user '%s'."

Jacob Nevins <jtn>
Project Administrator
Tue 06 Mar 2012 12:27:52 AM UTC, original submission:

When a server has authentication enabled and guest logins enabled (--Guests), in the event of a database error for a non-guest username, it falls back to connecting the user as a guest.

However, the server sends a chat message before the connection is established to explain to the client what's happened. The client doesn't like this; it says

and disconnects in disgust, rather defeating the point of the exercise.

Either the server shouldn't send the chat message, or the client should be more relaxed about receiving early chat messages (client_packet_input()), or possibly both.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #27081:  EarlyChat.patch added by cazfi (9kB - text/x-diff)

 

Depends on the following items: None found

Digest:
   task dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Updated the item)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 17 Apr 2016 03:56:29 AM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sun 10 Apr 2016 07:25:51 PM UTCcazfiAttached File-=>Added EarlyChat.patch, #27081
    Sun 10 Apr 2016 07:25:22 PM UTCcazfiStatusNone=>Ready For Test
    Wed 20 Jan 2016 07:56:57 PM UTCcazfiCategoryNone=>general
      Planned Release=>2.6.0, 3.0.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup