bugBattle for Wesnoth - Bugs: bug #19545, [unstore_unit] can advance units...

 
 
Show feedback again

bug #19545: [unstore_unit] can advance units only once

Submitted by:  Elvish_Hunter <elvish_hunter>
Submitted on:  Wed 14 Mar 2012 09:36:41 AM UTC  
 
Category: Feature RequestSeverity: 3 - Normal
Priority: 3 - LowItem Group: WML
Status: Ready For TestPrivacy: Public
Assigned to: Fabian Müller <fendrin>Open/Closed: Closed
Release: trunk and 1.10.1Operating System: All

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 29 Dec 2012 11:21:17 PM UTC, SVN revision 55956:

Implementing feature request bug #19545 by applying the patch provided and adding an additional break condition to prevent infinite looping.

(Browse SVN revision 55956)

Fabian Müller <fendrin>
Project MemberIn charge of this item.
Wed 14 Mar 2012 01:55:40 PM UTC, comment #1:

Couldn't find the IRC talk atm; but changing to FR since unstore_unit never behaved this way AFAICT and I don't think that it is unintentionally.
Furthermore, it may not be a good idea to do it this way. Imagine debugging-situations where you would possible have your gui blocked by repeated advancement choice dialogs. Thais could also be useful for other cases however, so perhaps a recursive= (def no) parameter ?

Anonymissimus <anonymissimus>
Project Member
Wed 14 Mar 2012 09:36:41 AM UTC, original submission:

It was reported here: http://forums.wesnoth.org/viewtopic.php?f=21&t=36292#p522605
that, if a unit with enough experience to advance twice or more is unstored, [unstore_unit] can fire the advancement only once.
With my basic C++ knowledge, I found that the following patch (that I'm copypasting, as it's just a line) enables [unstore_unit] to advance units until they no longer have enough XP to do so.

However, as I'm not a real C++ coder, I'm assigning this patch to fendrin, as we agreed on IRC.

Elvish_Hunter <elvish_hunter>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by fendrin (Updated the item)
  • -unavailable- added by anonymissimus (Posted a comment)
  • -unavailable- added by elvish_hunter (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 26 Mar 2013 12:49:44 PM UTCshadowmasterOpen/ClosedOpen=>Closed
    Sat 29 Dec 2012 11:22:08 PM UTCfendrinStatusNone=>Ready For Test
    Sun 27 May 2012 03:56:28 PM UTCfendrinPriority5 - Normal=>3 - Low
    Wed 14 Mar 2012 01:55:40 PM UTCanonymissimusCategoryBug=>Feature Request
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup