bugFreeciv - Bugs: bug #19733, fcdb: server frets about unset...

 
 
Show feedback again

bug #19733: fcdb: server frets about unset --Database config items even when they're not meaningful

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sun 13 May 2012 11:38:57 PM UTC  
 
Category: NoneSeverity: 2 - Minor
Priority: 5 - NormalStatus: Fixed
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Release: Operating System: Any
Planned Release: 2.4.0,2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 10 Jul 2012 08:49:33 AM UTC, SVN revision 21494:

Don't complain loudly about omitted keys in --Database file.

See gna bug #19733.

(Browse SVN revision 21494)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Tue 10 Jul 2012 08:47:33 AM UTC, SVN revision 21489:

Don't complain loudly about omitted keys in --Database file.

See gna bug #19733.

(Browse SVN revision 21489)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sun 08 Jul 2012 01:41:56 PM UTC, comment #1:

Attached patch just changes level to log_verbose. Deeper changes punted to bug #19909.

(file #16024)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sun 13 May 2012 11:38:57 PM UTC, original submission:

At the moment, the server is rather chatty/fussy about the contents of the --Database file (traditionally fc_auth.conf); if any item is missing, it will note this at log_normal level.

For instance, with SQLite, many of the keys make no sense. So with my SQLite script under development (patch #3287), I see this every time I start the server:

There are a couple of possible solutions:

  • Relegate the messages to log_verbose, or remove them entirely (low-impact option):
  • Stop the core Freeciv code caring about the set of keys entirely. It seems odd that the server carefully validates, translates, and restricts the set of items in the config file, when it makes no direct use of them subsequently; any meaning is ascribed to them entirely by database.lua. So the effect of this is to restrict extensibility in database.lua.
    • Presumably the idea is to warn the server operator they might have forgotten something, but it's counterproductive in the case of SQLite. Such warnings would probably be better implemented in database.lua.
    • I'm tempted to remove all knowledge of the keys from the server, and just expose the secfile contents to database.lua verbatim, via a Lua data structure or accessor function. This would likely change the Lua interface, but not necessarily the fc_auth.conf format.
    • (If it had been like this, I wouldn't have had to touch the server code to implement patch #3273.)

The right answer could be different for S2_4 and trunk.

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16024:  trunk-S2_4-fcdb-file-quell-complaints.patch added by jtn (953B - text/x-diff - trunk/S2_4 r21471)

 

Depends on the following items: None found

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 10 Jul 2012 08:57:36 AM UTCjtnStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sun 08 Jul 2012 01:41:56 PM UTCjtnAttached File-=>Added trunk-S2_4-fcdb-file-quell-complaints.patch, #16024
      StatusNone=>Ready For Test
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup