bugFreeciv - Bugs: bug #19745, Player scores excessively high in...

 
 
Show feedback again

bug #19745: Player scores excessively high in this savefile

Submitted by:  None
Submitted on:  Sat 19 May 2012 11:18:53 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Originator Email: -unavailable-
Open/Closed: ClosedRelease: 2.3.2
Operating System: GNU/LinuxPlanned Release: 2.3.3, 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 27 Jun 2012 08:31:52 PM UTC, SVN revision 21372:

Initialize player future techs counter.

Reported by Anonymous

See gna bug #19745

(Browse SVN revision 21372)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 27 Jun 2012 08:31:43 PM UTC, SVN revision 21371:

Initialize player future techs counter.

Reported by Anonymous

See gna bug #19745

(Browse SVN revision 21371)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 27 Jun 2012 08:31:33 PM UTC, SVN revision 21370:

Initialize player future techs counter.

Reported by Anonymous

See gna bug #19745

(Browse SVN revision 21370)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 27 Jun 2012 07:48:46 PM UTC, comment #5:

> Can't that be a valid game state, now that techs can be lost?


Yes, I was thinking checking ruleset for that (can techs be lost) too. But now I remembered that we used to have bug that techs could be lost with any ruleset. So I guess we do nothing but apply the initialization patch to prevent newly started games from getting free future techs.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 25 Jun 2012 09:39:55 PM UTC, comment #4:

> In theory we could try to fix old broken savegames by zeroing
> future tech count if there's undiscovered techs left while
> loading such a game.

Can't that be a valid game state, now that techs can be lost?

Jacob Nevins <jtn>
Project Administrator
Mon 25 Jun 2012 07:33:18 PM UTC, comment #3:

I added some logging to find out that score comes mainly from future techs.

Future techs count is never initialized. Fix for that attached.

In theory we could try to fix old broken savegames by zeroing future tech count if there's undiscovered techs left while loading such a game.

(file #15884)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 24 Jun 2012 11:50:49 AM UTC, comment #2:

In the original savegame, the scores are:

  • Gunnhill/philippe (Viking): 4
  • ?/Admin (Amazigh): 1295
  • Anna/AI (Brandenburgian): 1071
  • Elizabeth I/AI (English): 1165

This is at T18. Ruleset is "default". Leaders are in use.

@master: I'm not sure what to glean from your screenshot, which shows techs and not scores. It is T2 and shows the Hackers already with at least Alphabet and Horseback Riding; is your problem that you think Hackers already have too many techs in T2? Could Hackers not just have got lucky with huts? Quite a bit of the map is explored already.

Jacob Nevins <jtn>
Project Administrator
Sun 27 May 2012 12:58:41 AM UTC, comment #1:

Totally true you can see another example of this bug

Note: we set No free techs

http://i.imgur.com/RIWU0.png

Alberto Bonsanto <master>
Sat 19 May 2012 11:18:53 PM UTC, original submission:

Players of the server freeciv-debian.ns0.it reported that during a match they saw excessively high scores assigned to them compared to their actual states on game. This anomalous behaviour seemed to be present since turn 0 up to turn 18 when game was interrupted.
The attached savefile represents turn 18; most of the other auto-generated savefiles have been overwritten.
Server runs on GNU/Linux.
I don't know other details.

In the savefile, server version may be reported as "2.3.2+", but it's actually the 2.3.2 vanilla with a local and limited modification that, only under a triggering condition for which users vote (which wasn't satisfied for the referred game), preconfigures the map topology according to the amount of players, right after the "start game" button is pressed; otherwise it does nothing.

Anonymous

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #15884:  InitFutureTechs.diff added by cazfi (422B - text/x-patch)
file #15751:  freeciv-T0018-Y-3100-auto.sav.gz added by None (17kB - application/gzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Updated the item)
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by master (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 27 Jun 2012 08:32:15 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Mon 25 Jun 2012 07:33:18 PM UTCcazfiAttached File-=>Added InitFutureTechs.diff, #15884
      StatusNone=>Ready For Test
      Planned Release=>2.3.3, 2.4.0, 2.5.0
    Sat 19 May 2012 11:18:53 PM UTCNoneAttached File-=>Added freeciv-T0018-Y-3100-auto.sav.gz, #15751
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup