bugSavane - Bugs: bug #1980, Newlines are doubled in...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #1980: Newlines are doubled in notifications

Submitted by:  Sylvain Beucler <beuc>
Submitted on:  Wed 19 Jan 2005 04:24:25 PM UTC  
 
Category: Web Frontend: TrackersStatus: Works For Me
Severity: 3 - NormalPriority: A - Later
Assigned to: Sylvain Beucler <beuc>Open/Closed: Closed
Release: Planned Release: 1.0.6
Reproducibility: NonePrivacy: Public

(Jump to the original submission Jump to the original submission)

Mon 04 Jul 2005 09:45:27 AM UTC, comment #16:

3 month later, I think we can safely close the item. We will reopen it if necessary.

Mathieu Roy <yeupou>
Project Administrator
Wed 23 Mar 2005 07:38:24 AM UTC, comment #15:

We can keep the item open and update the status accordingly (Fixed if you dare or, or simply Work For Me).

Mathieu Roy <yeupou>
Project Administrator
Tue 22 Mar 2005 10:19:31 PM UTC, comment #14:

The workaround is effective, but it is not really tested again different kind of mailers.

I'd like to track this bug down, but I need to setup some better test install for this.

If you want to clean-up the bug list, I suggest creating a "long-term parking" category :)

Sylvain Beucler <beuc>
Project AdministratorIn charge of this item.
Mon 21 Mar 2005 03:15:31 PM UTC, comment #13:

I'm not sure how you see the discussion with mailman people but I does not looks like we'll have then to even suppose there may be a bug in their stuff.

4 messages saying this problem only occurs with mails transiting via mailman, they are still blaming another software for the bug.

So let's jump to conclusion:
We cannot seriously think of a php/exim sudden bug. PHP at gna is not on the same system than mailman. So whatever happens, mailman receive the mail from Savane just as if it was coming from anywhere else in the galaxy.

Is the s/\r\n/\n/ effective? If so, I think we can close the item.

Mathieu Roy <yeupou>
Project Administrator
Wed 16 Mar 2005 08:05:02 PM UTC, comment #12:

I applied a patch to s/\r\n/\n/, but I still wait for the Mailman crew to deal with their bug. I'll try to bug them at their mailing list instead :)

Sylvain Beucler <beuc>
Project AdministratorIn charge of this item.
Wed 16 Mar 2005 12:32:24 PM UTC, comment #11:

Sylvain, can you fix it (seems you have details about it)? If so, could you make an ETA? It would be good to have this item getting fixed before 1.0.6 and I'd like to release 1.0.6 soon (after the NEWSCM branch merge)

Mathieu Roy <yeupou>
Project Administrator
Fri 25 Feb 2005 08:46:27 AM UTC, comment #10:

Hum, I replied without reading your latest reply. I guess there is no need to submit a bug against the debian package if you reported the bug upstream.

Mathieu Roy <yeupou>
Project Administrator
Fri 25 Feb 2005 08:45:07 AM UTC, comment #9:

I'd say commit + submit a bug against the mailman package on debian.

Mathieu Roy <yeupou>
Project Administrator
Thu 24 Feb 2005 11:13:54 PM UTC, comment #8:

I submitted a bug report for Mailman:
https://sourceforge.net/tracker/index.php?func=detail&aid=1151439&group_id=103&atid=100103

Sylvain Beucler <beuc>
Project AdministratorIn charge of this item.
Thu 24 Feb 2005 10:51:07 PM UTC, comment #7:

I looked at the way phpBB handles the problem.
Answer: it doesnt, although it replaces \n by \r\n.
$message = preg_replace("#(?<!\r)\n#si", "\r\n", $message);

I similarly replaced \r\n by \n and Mailman was happy.
$message = str_replace("\r\n", "\n", $message);

RFC821 is very vague about what newline should be used during the DATA command, except that DATA should end with "<CRLF>.<CRLF>".

All in all, it looks like a bug in Mailman, but using a consistent (non-mixed) \n newline convention as I did does not break anything and makes Mailman happy.

Commit or not commit?

Sylvain Beucler <beuc>
Project AdministratorIn charge of this item.
Sat 19 Feb 2005 10:37:37 PM UTC, comment #6:

The problem is apparently that:
- the form is send using HTTP/DOS newlines (\r\n)
- the mail is sent with a mixture of \n (from Savane) and \r\n (from the 'details' field)

Some mailers translate \r\n to \n; Mailman translates \r\n to \n\n.

Now, I have been looking at the code.

Actually it looks like it has been that way for quite a while:
https://mail.gna.org/public/savane-dev/2003-08/msg00082.html

I'll try to find what is the reference document for the form-data Content-Disposition.

In the end I think we need to convert everything to \n before to send the notification.

Sylvain Beucler <beuc>
Project AdministratorIn charge of this item.
Fri 18 Feb 2005 11:09:58 AM UTC, comment #5:

For the record,

https://mail.gna.org/public/savane-dev/2005-02/msg00108.html
uses \n\n.

Both -unavailable- and -unavailable- receive correct direct notification (only 1 \n).

Well it must be mailman-related eventually, I guess..

Sylvain Beucler <beuc>
Project AdministratorIn charge of this item.
Fri 18 Feb 2005 10:53:56 AM UTC, comment #4:

None.

I got notification (Message-Id: <20050217-235033.sv561.76527@gna.org>) correct.

My mailer automatically shows \n\n like \n but even in raw mode there's no \n\n.

Quite hard to understand.

Mathieu Roy <yeupou>
Project Administrator
Thu 17 Feb 2005 11:50:33 PM UTC, comment #3:

I am really puzzled, because when I received notifications at beuc.net, I get them right, and when I receive it via the mailing lists, all new lines are doubled.

But, when I write long lines that wordwrap(), I get the paragraph right in both cases.

I wonder if beuc.net is not automatically stripping \n\n to \n if the duplication is consistent throghouth the message... anyway given what I said it can't come from Mailman alone.

Any clue?

Sylvain Beucler <beuc>
Project AdministratorIn charge of this item.
Wed 19 Jan 2005 04:52:18 PM UTC, comment #2:

sendmail_mail() make a call to wordwrap(). Could it be the cause of the extra \n added?

Mathieu Roy <yeupou>
Project Administrator
Wed 19 Jan 2005 04:46:34 PM UTC, comment #1:

It is right. I never noticed it because my mailer remove \n when it consider they are too many.

Mathieu Roy <yeupou>
Project Administrator
Wed 19 Jan 2005 04:24:25 PM UTC, original submission:

Looks like \n becomes \n\n in mail notifications. For example, check any approval notification that uses paragraphs already cut to 75 characters: you get a blank line between each line.

This paragraph will be preceded by 2 empty lines in the notification this bug report will generate. I only separated the 2 paragraphs by 1 empty line.

Sylvain Beucler <beuc>
Project AdministratorIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one

Digest:
   task dependencies.

 

Carbon-Copy List
  • -unavailable- added by yeupou (Posted a comment)
  • -unavailable- added by beuc (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 04 Jul 2005 09:45:27 AM UTCyeupouOpen/ClosedOpen=>Closed
    Fri 01 Apr 2005 08:50:27 AM UTCyeupouPriorityD - High=>A - Later
    Sat 26 Mar 2005 08:29:49 AM UTCyeupouStatusNeed Info=>Works For Me
    Mon 21 Mar 2005 06:39:32 PM UTCyeupouStatus101(Error - Not Found)=>Need Info
    Mon 21 Mar 2005 11:53:23 AM UTCyeupouPlanned Release=>1.0.6
    Wed 16 Mar 2005 08:05:02 PM UTCbeucStatus102(Error - Not Found)=>101(Error - Not Found)
    Wed 16 Mar 2005 12:32:24 PM UTCyeupouPriorityA - Later=>D - High
      StatusNone=>102(Error - Not Found)
    Thu 24 Feb 2005 10:51:07 PM UTCbeucAssigned toNone=>beuc
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup