Disabled non-functional tile vision editing dialog

See bug #19825

(Browse SVN revision 22649)

I meant to just inspect the case, but ended with attached stop-gag patch for S2_4. It simply disables non-functional vision dialog from the editor. Code to handle it is still left there in case we decide to make something of it in TRUNK.

Vision dialog was just trying to show vision status of the tile of each player. Without server not sending the information that meant always showing nothing. It was not possible to edit the information from the dialog even in the case of attached player. It would be impossible in the case of FoW status anyway - either something (unit/city) provides the vision or not.

(file #17571)

> I would say that the UI should match what the client's player
> know. But maybe global observer should know the vision of each
> player in edit mode (of course, this would require more work).

I think I could implement this. But I would need a new packet (PACKET_PLAYER_TILE_INFO).

> However, back to this case, it would probably be reasonable for
> the editor to realise it will never get vision data for more
> than at most the current player, and change its UI accordingly.

I want consistent policy over these issues instead of deciding separately for each.

I think our options are:
1) Rework the UI to match the fact that you don't know other player's stuff. Make it impossible to edit other players -> require one to 'take' player they want to edit.
2) Send all required information in edit mode (including completele refresh when entering or leaving edit mode)

There's one thing I would miss from current editor if we go by (1): ability to place enemy units/cities relative to my own units position, often to place enemy has not even mapped anywhere near (guessing correct location as the enemy would be pain)

(2) is probably more painful to maintain as we add new fields to send at some situations, but not on others etc. Also takes more memory in client side as it needs to be prepared to get information about all players (reverting bug #18192)

I think this has been exposed by bug #18192.

In the edit dialog, for the Tile tab, the editor tries to display a table of which players can see the tile ("Vision", OPID_TILE_VISION), so it's trying to look at every player's tile_known. But in bug #18192, those got replaced by a dummy for non-client players.
Quite why the editor thinks it can know this as a client I'm not sure; I don't think there's any situation, even global observer, where the server keeps the client up-to-date on everyone's vision.

This is an extreme case of a general approach in the editor of letting you see / attempt to interact with other players' stuff (e.g., player properties such as gold, city properties such as food stock), where it displays values but they're just dummy values such as 0, because the client doesn't know the real values. If you try to change them, they just mutely stay red when you hit Apply.

I suppose the editor can't very well track what it's "supposed" to know -- the server mostly doesn't explicitly tell the client "I'm withholding field X from you", and where it does (SHORT_INFO), the client doesn't make a note of this. Having the editor try to second-guess which fields are valid from the client side would probably be fragile.

However, back to this case, it would probably be reasonable for the editor to realise it will never get vision data for more than at most the current player, and change its UI accordingly.

Just seen a bunch of these on my client console with S2_4 r21328ish. I did use edit mode (cf bug #19300).

Here's the one from nearest the top of my scrollback (not the first, there were many):