bugFreeciv - Bugs: bug #19886, Mapgen assert fails if ruleset has...

 
 
Show feedback again

bug #19886: Mapgen assert fails if ruleset has no unit with role requested first in startunits

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Sun Jul 1 14:42:05 2012  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.3.4, 2.4.0, 2.5.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon Jan 14 21:12:14 2013, SVN revision 22123:

In case ruleset has no unit matching first role in startunits, select next one
until one exist to be used as unit for checking start position suitability.
Previously NULL unit was used in such a case resulting failure deep in the
mapgenerator code.

See gna bug #19886

(Browse SVN revision 22123)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon Jan 14 21:12:08 2013, SVN revision 22122:

In case ruleset has no unit matching first role in startunits, select next one
until one exist to be used as unit for checking start position suitability.
Previously NULL unit was used in such a case resulting failure deep in the
mapgenerator code.

See gna bug #19886

(Browse SVN revision 22122)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon Jan 14 21:12:03 2013, SVN revision 22121:

In case ruleset has no unit matching first role in startunits, select next one
until one exist to be used as unit for checking start position suitability.
Previously NULL unit was used in such a case resulting failure deep in the
mapgenerator code.

See gna bug #19886

(Browse SVN revision 22121)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun Jan 13 05:38:11 2013, comment #1:

- Fix

(file #16919, file #16920)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun Jul 1 14:42:05 2012, original submission:

If startunits start with a role for which there is no unit in ruleset, result is mystic assert failure in map generation. Either we should work around (use next unit in startunits for selecting startposition) or at the very least give more sensible error message.

srv_main.c:2467- happily passes NULL initial_unit to map_fractal_generate():

struct unit_type *utype = crole_to_unit_type(game.server.start_units[0], NULL);

for (i = 0; !created && i < max ; i++) {
created = map_fractal_generate(TRUE, utype);

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon Jan 14 21:12:27 2013cazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sun Jan 13 05:38:11 2013cazfiAttached File-=>Added SearchPossibleStartUnit-S2_3.patch, #16919
      Attached File-=>Added SearchPossibleStartUnit.patch, #16920
      CategoryNone=>general
      StatusNone=>Ready For Test
      Planned Release=>2.3.4, 2.4.0, 2.5.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup