bugFreeciv - Bugs: bug #19894, Cannot load savegame of...

 
 
Show feedback again

bug #19894: Cannot load savegame of barbarianless ruleset

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Tue 03 Jul 2012 10:18:24 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: Operating System: None
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 06 Jul 2012 07:19:45 PM UTC, comment #2:

Attaching what I did so far to this ticket just for safekeeping. In short term I'm more likely to just provide dummy barbarians in my ruleset than working on this further.

(file #15993)

Marko Lindqvist <cazfi>
Project Administrator
Fri 06 Jul 2012 06:49:17 PM UTC, comment #1:

As ruleset is loaded first and settings reseted, or even changed by humans, later, checks and restrictions should apply at the time of setting barbarianrate setting. Not that it would be trivial to implement either - when resetting to default values, default value for barbarianrate is sometimes illegal value to set.

Marko Lindqvist <cazfi>
Project Administrator
Tue 03 Jul 2012 10:18:24 PM UTC, original submission:

$subject is actually just one side of the bug I've so far managed to work around.
It should be possible to load ruleset without barbarian unit types, if barbarians are disabled from the game. Game starting sequence is such that this succeeds only if barbarians were disabled before ruleset loading started - this is even more counterintuitive remembering that ruleset loading resets the settings, so usually there's no point at all to set some settings before setting rulesetdir.
For initial loading of the ruleset I have primitive.serv like this:

set barbarians DISABLED
rulesetdir primitive

and in game.ruleset:

[settings]
set =
{ "name", "value", "lock"
"barbarians", "DISABLED", TRUE
}

Former allows loading of the ruleset, latter sets barbarians disabled also after ruleset loading resets the setting.

Now that I have played such a game, and saved it (as a scenario, but I don't think that makes any difference), I'm unable to load savegame. There's no way to make server disable the barbarians before ruleset is loaded.

Marko Lindqvist <cazfi>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #15993:  BarbariansValidate.patch added by cazfi (5kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 06 Jul 2012 07:19:45 PM UTCcazfiAttached File-=>Added BarbariansValidate.patch, #15993
      CategoryNone=>general
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup