bugFreeciv - Bugs: bug #19904, Unit displayed as loaded, but...

 
 
Show feedback again

bug #19904: Unit displayed as loaded, but transport doesn't show it as passenger (or carry it)

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat Jul 7 16:09:27 2012  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Duplicate
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: S2_4 r21463Operating System: GNU/Linux
Planned Release: 2.4.0,2.5.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun Jan 4 06:50:25 2015, comment #9:

As number of similar bugs have been fixed, and nobody has reported seeing this in a long time, closing as duplicate.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed Oct 22 08:04:35 2014, comment #8:

Has anyone observed this bug recently? It has been probably fixed by another way since it was reported.

pepeto <pepeto>
Project Member
Tue Aug 21 23:39:52 2012, comment #7:

See bug #20085 for fix of some of these problems.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun Aug 19 10:45:46 2012, comment #6:

Friend of mine reports new developments with "ghost" unit in his boat. The unit in question was unloaded to shore, but appears also as loaded to his ship.

For one we know that his is not client side problem (only) as the situation remains over logout/login cycle.

Now the unit on shore was killed - but it still exist in his ship, taking transport capacity.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat Aug 18 22:46:17 2012, SVN revision 21813:

Added sanity checking that units listed as cargo of unit list that
unit as their transport in return.

See gna bug #19904

(Browse SVN revision 21813)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri Aug 17 00:45:08 2012, comment #4:

So, server side nowadays stores unit's transporter as pointer, but client still uses separate transporter id field! I wonder how well common code copes.

Attached is added sanity checking for server side (but I'm quite sure this is client side problem)

(file #16399)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri Aug 17 00:27:16 2012, comment #3:

I've seen this quite regularly, but not reproducible cases. It seems that unit unloading method does not matter - I've seen it with units simply moving out of boat, ships Shift+T unloading in cities, unloading at coast.

Maybe related thing is that in a coastal city where I were loading units to ship there was more to load (from main map) than I anticipated. Once I opened city screen to check the situation, it was revealed to me that I had loading also those units that were supposed to be fortified to the city. I unloaded those units one by one (via city screen present units -> menu). That went fine. But as I were fortifying last one them, another one of the units got unfortified. I fortified that, and again another (seemingly random) unit got unfortified. I continued this a while, and found out that putting unit on Sentry worked the same - random other unit lost its fortified or sentried activity.
I then moved ship (with its single passanger (which was sentried all the time - it never lost that status, by the way - not that I know when it had first became sentried)) out of the city, and tried to fortify units remaining in the city again. This time it worked just as it should.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat Jul 7 20:48:33 2012, comment #2:

I'd completely forgotten that one. Yes, could be. No wipe_unit() or goto involved this time.

Jacob Nevins <jtn>
Project Administrator
Sat Jul 7 19:54:34 2012, comment #1:

Likely to be related to bug #19612?

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat Jul 7 16:09:27 2012, original submission:

Recently I somehow got into a state where the client showed a unit as (L)oaded, but there was no transport present; I'd previously loaded and unloaded it from a transport, then moved the transport. Depending precisely how I viewed the transport, it either thought it had the unit on board or didn't. The unit could not be unloaded to clear this state.

Unfortunately it doesn't reproduce from a savegame, so this bug will have to be a collector for other instances, but the attached screenshot should show something is up (Diplomat loaded on... what?)

What I did was something like:

  • Load a bunch of units including a Diplomat onto the Galleon, in a city.
  • Changed my mind about the Diplomat and (tried to) unload it. (Possibly I did something wrong/unusual at the point, I wasn't paying close attention.)
  • Moved the Galleon out of the city.
  • Started noticing weirdness in the client display.

It's possible this is a client-side issue (or that the server didn't send enough info to the client).

This is S2_4 r21463 (experimental ruleset, Gtk2 client). I'm guessing it was introduced by recursive-transports or the unit select dialog.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16399:  CargoSanity.patch added by cazfi (638B - text/x-diff)
file #16006:  S2_4-r21463-unit842-notloaded-on-unit581.png added by jtn (268kB - image/png - screenshot of problem (S2_4 r21463): what's the Diplomat loaded on?)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by pepeto (Posted a comment)
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun Jan 4 06:50:25 2015cazfiStatusNeed Info=>Duplicate
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Wed Oct 22 08:04:35 2014pepetoCategoryNone=>general
    Sun Apr 7 10:09:21 2013jtnDependencies-=>bugs #20722 is dependent
    Fri Aug 17 00:45:08 2012cazfiAttached File-=>Added CargoSanity.patch, #16399
    Sat Jul 7 16:09:27 2012jtnAttached File-=>Added S2_4-r21463-unit842-notloaded-on-unit581.png, #16006
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup