bugFreeciv - Bugs: bug #19909, fcdb options should not be...

 
 
Show feedback again

bug #19909: fcdb options should not be defined/checked by freeciv-server

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sun 08 Jul 2012 12:08:00 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Release: Operating System: Any
Planned Release: 2.5.0,2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 17 Feb 2014 10:03:15 AM UTC, SVN revision 24501:

Valid keys and their meanings in the database configuration file are now
defined by database.lua, not freeciv-server.

See gna bug #19909.

(Browse SVN revision 24501)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 17 Feb 2014 09:56:53 AM UTC, SVN revision 24496:

Valid keys and their meanings in the database configuration file are now
defined by database.lua, not freeciv-server.

See gna bug #19909.

(Browse SVN revision 24496)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sat 15 Feb 2014 09:32:24 PM UTC, comment #4:

Commit candidate.

Some net changes, not all of which might be obvious from the patch:

  • Default backend changed from MySQL to SQLite
  • Many fewer defaults in the system (just backend/table_user/table_log, everything else must now be explicitly specified)
  • No longer checks syntax of 'port' is numeric
  • No longer attempts to warn about unused entries in config file
  • Debug logging moved from server into database.lua

(file #20071)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Thu 13 Feb 2014 01:24:56 AM UTC, comment #3:

Attached my WIP patch as it's been in my git for some weeks, to give some idea what I'm planning.
It fixes the format of the Lua script but not necessarily of the database configuration file.

(file #20028)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sun 12 Jan 2014 01:56:36 PM UTC, comment #2:

> What's the status?

I'd completely forgotten about it. I'm on the case.

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 06 Jan 2014 05:14:36 AM UTC, comment #1:

This is currently marked as blocker for 2.5 datafile format freeze. What's the status?

Marko Lindqvist <cazfi>
Project Administrator
Sun 08 Jul 2012 12:08:00 PM UTC, original submission:

For the reasons described in bug #19733, it would be better if the server could just pass all the key/value pairs from the --Database file (fc_auth.conf) to the Lua script rather than trying to interpret them itself.

This will probably change the Lua interface.

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20071:  trunk-S2_5-fcdb-arbitrary-keys.patch added by jtn (25kB - text/x-patch - trunk/S2_5 r24474)
file #20028:  trunk-fcdb-vars-wip.patch added by jtn (13kB - text/x-patch - trunk r24447: work in progress)

 

Depends on the following items: None found

Digest:
   task dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 17 Feb 2014 10:08:50 AM UTCjtnStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sat 15 Feb 2014 09:32:24 PM UTCjtnAttached File-=>Added trunk-S2_5-fcdb-arbitrary-keys.patch, #20071
      StatusIn Progress=>Ready For Test
      Planned Release2.5.0=>2.5.0,2.6.0
    Thu 13 Feb 2014 01:24:56 AM UTCjtnAttached File-=>Added trunk-fcdb-vars-wip.patch, #20028
    Sun 12 Jan 2014 01:56:36 PM UTCjtnStatusNone=>In Progress
      Assigned toNone=>jtn
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup