bugFreeciv - Bugs: bug #19911, fcdb: database.lua should not be...

 
 
Show feedback again

bug #19911: fcdb: database.lua should not be searched for on paths overridable by modpack

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sun 08 Jul 2012 04:55:30 PM UTC  
 
Category: NoneSeverity: 4 - Important
Priority: 5 - NormalStatus: Fixed
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Release: Operating System: Any
Planned Release: 2.4.0,2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 10 Jul 2012 08:49:42 AM UTC, SVN revision 21496:

Moved install location of database.lua from general Freeciv data path
to hardcoded sysconfdir (e.g., /usr/local/etc/freeciv/database.lua)
for security reasons.
(After this, it will no longer be possible to run the server with a
--Database argument from a build directory; it must be installed.)

Patch by Marko Lindqvist (cazfi@gna) and myself.

See gna bug #19911.

(Browse SVN revision 21496)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Tue 10 Jul 2012 08:47:39 AM UTC, SVN revision 21491:

Moved install location of database.lua from general Freeciv data path
to hardcoded sysconfdir (e.g., /usr/local/etc/freeciv/database.lua)
for security reasons.
(After this, it will no longer be possible to run the server with a
--Database argument from a build directory; it must be installed.)

Patch by Marko Lindqvist (cazfi@gna) and myself.

See gna bug #19911.

(Browse SVN revision 21491)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sun 08 Jul 2012 04:55:30 PM UTC, original submission:

Split out from bug #19729: the script database.lua is currently searched for on the same path as data files, but it's too powerful for it to be safe to allow random modpacks to override it.

The attached patches (based on file #16014, file #16015, and originally from cazfi) search for it at a single (installed) location.
(Compared to the previous patches, these ones update README.fcdb.)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16030:  trunk-dbluaLoc-ter.patch added by jtn (4kB - text/x-diff - trunk/S2_4 r21471 + patch #3287)
file #16031:  S2_4-dbluaLoc-ter.patch added by jtn (5kB - text/x-diff - trunk/S2_4 r21471 + patch #3287)

 

Digest:
   patch dependencies.

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 10 Jul 2012 08:58:27 AM UTCjtnStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sun 08 Jul 2012 05:23:34 PM UTCjtnDependencies-=>bugs #19729 is dependent
    Sun 08 Jul 2012 05:21:56 PM UTCjtnAttached File-=>Added trunk-dbluaLoc-ter.patch, #16030
      Attached File-=>Added S2_4-dbluaLoc-ter.patch, #16031
      StatusIn Progress=>Ready For Test
      Dependencies-=>Depends on patch #3287
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup