bugFreeciv - Bugs: bug #19922, Too easy to lose boats when city...

Show feedback again

bug #19922: Too easy to lose boats when city lost to migration?

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Wed Jul 11 01:02:15 2012  
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: S2_4 r21510Operating System: None
Planned Release: Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Wed Jan 23 18:04:58 2013, comment #2:

> previously, I think the only time a city could disappear with
> units still in it would be build-settler-at-size-1

I've seen AI city to starve to death, but that's rather special case of AI-class-stupidity city placement (middle of arctic mountain range)

Marko Lindqvist <cazfi>
Project Administrator
Sun Jul 15 12:59:59 2012, comment #1:

> Or we could just use bounce_unit()

Patch #1254 talks about generalising this function.

Jacob Nevins <jtn>
Project Administrator
Wed Jul 11 01:02:15 2012, original submission:

I just moved a boat into a size 1 city, using all its movement points, and then the next turn, the city was disbanded due to migration. I lost the boat! Messages:

  • This unit has no moves left.
  • This unit has no moves left.
  • When Salzburg was disbanded your Ironclad could not get out, and it was therefore lost.

I felt rather aggrieved by this (it was elite), but I'm not sure if I should just take it.

If so, the messages need clearing up -- the "no moves left" message appears twice because unit_move_handling() is called for every adjacent ocean tile (here there were two) and emits this each time. The message doesn't make sense when it's not a user's direct action that caused the move.

But perhaps we should have an "emergency" mode for unit_move_handling() ignoring moves left and other things like ZOC, unitwaittime, etc that I think the current code falls foul of.

Or we could just use bounce_unit(), or do something like bounce_units_on_terrain_change() does. (Perhaps all these special cases should be unified?)

While I suspect remove_city() hasn't changed forever, I guess the forced-city-disband situation is new with migration -- previously, I think the only time a city could disappear with units still in it would be build-settler-at-size-1, where the player could be expected to plan for this?

Jacob Nevins <jtn>
Project Administrator


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup