bugFreeciv - Bugs: bug #19946, "Déjà vu" unit...

 
 
Show feedback again

bug #19946: "Déjà vu" unit movement animation in client

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sun Jul 15 17:35:02 2012  
 
Category: clientSeverity: 2 - Minor
Priority: 5 - NormalStatus: Fixed
Assigned to: pepeto <pepeto>Open/Closed: Closed
Release: S2_3 r21550Operating System: GNU/Linux
Planned Release: 2.4.4, 2.5.0, 2.6.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed Oct 22 17:41:35 2014, SVN revision 26827:

Make find_visible_unit() not returning the moving unit, to avoid to see the
unit drawn many times at the screen.

Reported by Jacob Nevins

See gna bug #19946

(Browse SVN revision 26827)

pepeto <pepeto>
Project MemberIn charge of this item.
Wed Oct 22 17:41:31 2014, SVN revision 26826:

Make find_visible_unit() not returning the moving unit, to avoid to see the
unit drawn many times at the screen.

Reported by Jacob Nevins

See gna bug #19946

(Browse SVN revision 26826)

pepeto <pepeto>
Project MemberIn charge of this item.
Wed Oct 22 17:41:27 2014, SVN revision 26825:

Make find_visible_unit() not returning the moving unit, to avoid to see the
unit drawn many times at the screen.

Reported by Jacob Nevins

See gna bug #19946

(Browse SVN revision 26825)

pepeto <pepeto>
Project MemberIn charge of this item.
Mon Oct 20 22:17:07 2014, comment #9:

This patch should do the trick.

(file #22680)

pepeto <pepeto>
Project MemberIn charge of this item.
Mon Oct 20 21:21:26 2014, comment #8:

It doesn't work at all currently. I will try to find something more robust...

pepeto <pepeto>
Project MemberIn charge of this item.
Mon Oct 20 21:03:21 2014, comment #7:

> This is partly reverted

What shall I report in release notes? Does the fix still basically work? Indeed, is the code releaseable in its current state?

Jacob Nevins <jtn>
Project Administrator
Thu Oct 9 03:08:58 2014, comment #6:

This is partly reverted as cause of bug #22770.

Marko Lindqvist <cazfi>
Project Administrator
Wed Oct 8 22:32:19 2014, SVN revision 26742:

Remove "D?\195?\169j?\195?\160 vu" unit movement animation in client.

Reported by Jacob Nevins

See gna bug #19946

(Browse SVN revision 26742)

pepeto <pepeto>
Project MemberIn charge of this item.
Wed Oct 8 22:32:15 2014, SVN revision 26741:

Remove "D?\195?\169j?\195?\160 vu" unit movement animation in client.

Reported by Jacob Nevins

See gna bug #19946

(Browse SVN revision 26741)

pepeto <pepeto>
Project MemberIn charge of this item.
Wed Oct 8 22:31:24 2014, SVN revision 26740:

Remove "D?\195?\169j?\195?\160 vu" unit movement animation in client.

See gna bug #19946

(Browse SVN revision 26740)

pepeto <pepeto>
Project MemberIn charge of this item.
Tue Oct 7 10:26:13 2014, comment #2:

Attached patch for do_move_unit() (inspired from the corresponding part of warclient r869).

(file #22569, file #22570, file #22571)

pepeto <pepeto>
Project MemberIn charge of this item.
Sat Jul 28 00:53:38 2012, comment #1:

I have also seen it for long time, I hope someone can fix it.

David Fernandez <bardo>
Sun Jul 15 17:35:02 2012, original submission:

This is something I've been seeing for years, but I've finally raised a ticket now that a commenter in bug #19921 confirms I wasn't dreaming it.

Sometimes when a unit is moving from one tile to another on the map, a copy of it instantly appears at its destination and then the unit moves from the source tile on top of the copy.

This can be seen more clearly by setting the "Unit movement animation time" to something like 1000ms.

The attached screen capture videos demonstrate what might be two distinct cases:

  • dejavu1.ogv: unit (Transport) moves into city; full copy of unit appears on city tile. (But in other cases I've only seen a partial copy.)
  • dejavu2.ogv: unit (Partisan) moving around tiles which each contain another unit (Engineer). Here only the part of the destination tile which impinges on the bounding box of the source tile seems to get the "déjà vu" effect.

Attached S2_3 savegame was saved before these movements took place.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #22680:  deja_vu.patch added by pepeto (2kB - text/x-patch)
file #22570:  S2_5_do_move_unit.patch added by pepeto (2kB - text/x-patch)
file #22571:  S2_4_do_move_unit.patch added by pepeto (2kB - text/x-patch)
file #22569:  trunk_do_move_unit.patch added by pepeto (2kB - text/x-patch)
file #16107:  test-dejavu.sav.bz2 added by jtn (15kB - application/x-bzip - savefile + screen capture videos, S2_3 r21550, 1000ms animation time, Amplio2 tileset)
file #16108:  dejavu1.ogv added by jtn (64kB - video/ogg - savefile + screen capture videos, S2_3 r21550, 1000ms animation time, Amplio2 tileset)
file #16109:  dejavu2.ogv added by jtn (686kB - video/ogg - savefile + screen capture videos, S2_3 r21550, 1000ms animation time, Amplio2 tileset)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by pepeto (Updated the item)
  • -unavailable- added by bardo (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 20 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed Oct 22 17:41:45 2014pepetoStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Mon Oct 20 22:17:07 2014pepetoAttached File-=>Added deja_vu.patch, #22680
      StatusNone=>Ready For Test
    Mon Oct 20 21:21:26 2014pepetoAssigned toNone=>pepeto
    Thu Oct 9 05:49:45 2014pepetoStatusFixed=>None
      Assigned topepeto=>None
      Open/ClosedClosed=>Open
    Wed Oct 8 22:32:30 2014pepetoStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue Oct 7 10:26:13 2014pepetoAttached File-=>Added trunk_do_move_unit.patch, #22569
      Attached File-=>Added S2_5_do_move_unit.patch, #22570
      Attached File-=>Added S2_4_do_move_unit.patch, #22571
      StatusNone=>Ready For Test
      Assigned toNone=>pepeto
      Planned Release=>2.4.4, 2.5.0, 2.6.0
    Sun Jul 15 21:48:54 2012jtnSummary"Déjà vu" unit movements in client=>"Déjà vu" unit movement animation in client
    Sun Jul 15 17:35:02 2012jtnAttached File-=>Added test-dejavu.sav.bz2, #16107
      Attached File-=>Added dejavu1.ogv, #16108
      Attached File-=>Added dejavu2.ogv, #16109
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup