bugFreeciv - Bugs: bug #19975, dialogs.c:597:7: error: array...

 
 
Show feedback again

bug #19975: dialogs.c:597:7: error: array subscript is above array bounds [-Werror=array-bounds]

Submitted by:  Matthias Pfafferodt <syntron>
Submitted on:  Tue 24 Jul 2012 06:26:34 PM UTC  
 
Category: client-xawSeverity: 3 - Normal
Priority: 5 - NormalStatus: Duplicate
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: S2_4 (svn21612)Operating System: GNU/Linux
Planned Release: 2.4.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 18 Feb 2013 09:53:02 AM UTC, SVN revision 22371:

Remove compilation error when compiling the Xaw client:
dialogs.c:597:7: error: array subscript is above array bounds

Reported by sytron and me.
Patch copied from jdorge's one for bug #15747 and bug #15821

See gna bug #19975 and bug #20514

(Browse SVN revision 22371)

pepeto <pepeto>
Project Member
Mon 18 Feb 2013 09:52:58 AM UTC, SVN revision 22370:

Remove compilation error when compiling the Xaw client:
dialogs.c:597:7: error: array subscript is above array bounds

Reported by sytron and me.
Patch copied from jdorge's one for bug #15747 and bug #15821

See gna bug #19975 and bug #20514

(Browse SVN revision 22370)

pepeto <pepeto>
Project Member
Sat 16 Feb 2013 01:30:57 AM UTC, comment #5:

bug #20514 has patch for this.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 14 Jan 2013 07:35:04 AM UTC, comment #4:

> Is this to be solved for 2.4.x? Or can this version only be
> compiled without extra checks?


First I'd like to have 100% certainty whether there might be a bug hidden in freeciv or is it just compiler heuristic giving false warning. I don't see anything wrong with the freeciv code, but I may have missed something.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 13 Jan 2013 03:30:01 PM UTC, comment #3:

still valid for all S2_4 i586 builds (svn 22113) ...

(matrix with all build tests at https://build.opensuse.org/project/monitor?project=home%3Asyntron%3Afreeciv)

Matthias Pfafferodt <syntron>
Project Member
Sun 18 Nov 2012 05:14:17 PM UTC, comment #2:

Is this to be solved for 2.4.x? Or can this version only be compiled without extra checks?

Matthias Pfafferodt <syntron>
Project Member
Tue 24 Jul 2012 06:52:12 PM UTC, comment #1:

> This error does not happens for trunk - was there a change with
> regard to this code?


Yes, data structures related to pillaging (and other targeted actions) have been rearranged in trunk for supporting gen-road building.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 24 Jul 2012 06:26:34 PM UTC, original submission:

I get the following compiling error for S2_4 on i586. It seems to be something arch specific as x86 finishes its build process:

[ 861s] dialogs.c: In function 'popup_pillage_dialog':
[ 861s] dialogs.c:597:7: error: array subscript is above array bounds [-Werror=array-bounds]
[ 861s] cc1: all warnings being treated as errors

The build has '--enable-debug=yes'. The complete log can be found at:

https://build.opensuse.org/package/live_build_log?arch=i586&package=freeciv-2.4svn&project=home%3Asyntron%3Afreeciv&repository=openSUSE_Tumbleweed

This error does not happens for trunk - was there a change with regard to this code? Or is this all a red herring?

Matthias Pfafferodt <syntron>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Updated the item)
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by syntron (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 16 Feb 2013 01:30:57 AM UTCcazfiStatusNone=>Duplicate
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Wed 13 Feb 2013 09:56:15 PM UTCjtnPlanned Release=>2.4.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup