bugFreeciv - Bugs: bug #19984, Client's limited knowledged used...

 
 
Show feedback again

bug #19984: Client's limited knowledged used when displaying military unhappiness caused by unit

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Thu 26 Jul 2012 08:33:20 AM UTC  
 
Category: clientSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: Operating System: None
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 26 Jul 2012 08:33:20 AM UTC, original submission:

Client can display completely bogus information about military unhappiness caused by units, since it tries to determine it itself with its limited knowledge. I have not checked all clients carefully, but from quick grepping it seems that broken code exist in all of them.

gtk3-client:
city_dialog_update_supported_units():
1. It gets value of effect EFT_MAKE_CONTENT_MIL to decide how many units get free upkeep. Client may end up displaying wrong number of units free of happiness upkeep
2. It calls city_unit_unhappiness() for each unit, which for units in fortress ends up checking if there's friendly city nearby. There could be allied city near that player does not know about (it would make sense that unknown cities would not lift unhappiness, but as server side does not work that way, client ends showing wrong information)

Marko Lindqvist <cazfi>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup