bugFreeciv - Bugs: bug #19994, In rulesets, support...

 
 
Show feedback again

bug #19994: In rulesets, support "preferred_*" as well as misspelled "prefered_*"

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat 28 Jul 2012 01:27:55 PM UTC  
 
Category: generalSeverity: 1 - Wish
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 28 Jan 2013 04:09:05 PM UTC, SVN revision 22229:

For various "prefered_" variables in rulesets and tilesets, accept
and even prefer also ones written as "preferred_"

Reported by Jacob Nevins

See gna bug #19994

(Browse SVN revision 22229)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 25 Jan 2013 01:21:31 AM UTC, comment #2:

Patch

Even for newly added "preferred_soundset" alternative form "prefered_soundset" is still supported. When adding new entry to a ruleset where old "prefered_tileset" already exist, it would be rather confusing if copypaste to similar "prefered_" entry wouldn't work.

(file #17019)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 28 Jul 2012 11:19:27 PM UTC, comment #1:

So in those time immemorial I should have believed myself, and not to "fix" spelling in my patch to one widely used in our codebase.

grep "prefered". I think there is at least "prefered_theme" defined in tilesets.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 28 Jul 2012 01:27:55 PM UTC, original submission:

Since time immemorial we've had the ruleset option "prefered_tileset", where "prefered" is a misspelling of "preferred".

It's probably too late to change that now, but we can easily support the correct spelling as well as the traditional one.

This is rather petty, but it's easy to fix, and I think worth doing -- it's rather easy to have a blind spot for this when scratching your head "why isn't it accepting my syntax"?

In 2.5 we're also getting "prefered_soundset" (patch #3226). Since that's not yet been released, we could just correct the spelling.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17019:  PreferPreferred.patch added by cazfi (2kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 28 Jan 2013 04:09:23 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Fri 25 Jan 2013 01:21:31 AM UTCcazfiAttached File-=>Added PreferPreferred.patch, #17019
      CategoryNone=>general
      StatusNone=>Ready For Test
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup