bugFreeciv - Bugs: bug #20008, Tileset priority not respected

 
 
Show feedback again

bug #20008: Tileset priority not respected

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Mon 30 Jul 2012 10:06:20 PM UTC  
 
Category: clientSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.3.5, 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 27 Feb 2013 09:08:57 PM UTC, SVN revision 22456:

Fixed initial selection of default tileset on new freeciv installations
to correctly consider tileset priority instead of just selecting the
first working one in alphabetical order.

See bug #20008

(Browse SVN revision 22456)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 27 Feb 2013 09:08:49 PM UTC, SVN revision 22455:

Fixed initial selection of default tileset on new freeciv installations
to correctly consider tileset priority instead of just selecting the
first working one in alphabetical order.

See bug #20008

(Browse SVN revision 22455)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Wed 27 Feb 2013 09:08:42 PM UTC, SVN revision 22454:

Fixed initial selection of default tileset on new freeciv installations
to correctly consider tileset priority instead of just selecting the
first working one in alphabetical order.

See bug #20008

(Browse SVN revision 22454)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 23 Feb 2013 08:59:05 AM UTC, comment #4:

Well, it seems that one can get away with this simple trick: Set empty string as default instead of NULL, so dynamic detection of default tileset is avoided in options code. Tilespec code can then add real default tileset.

(file #17324, file #17325)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 23 Feb 2013 08:34:05 AM UTC, comment #3:

I had unfinished fix for this on old machine, but I'm afraid that's lost.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 31 Jul 2012 11:18:39 PM UTC, comment #2:

See also bug #17175.

Jacob Nevins <jtn>
Project Administrator
Mon 30 Jul 2012 10:29:35 PM UTC, comment #1:

1. First client gets list of possible default_tile_name values with get_tileset_list() that does not care about priority at all - I assume it returns them in alphabetical order.
2. First value from that list is assigned as initial default_tile_name value.
3. tilespec_try_read() would assign tileset by priority if there's no tileset selected, but as assignment in 2) makes it seems like user has selected amplio, it doesn't override that decision.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon 30 Jul 2012 10:06:20 PM UTC, original submission:

Commenting out default_tileset_name from freeciv-client-2.5 causes client to start with amplio (and not amplio2) tileset (this is, of course, running from svn checkout where amplio is present).

amplio2's priority is 30, and amplio's priority 20, so the priority is not working as expected.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #17324:  NotFirstTileset.patch added by cazfi (1kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 27 Feb 2013 09:09:10 PM UTCcazfiStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sat 23 Feb 2013 08:59:05 AM UTCcazfiAttached File-=>Added NotFirstTileset.patch, #17324
      Attached File-=>Added NotFirstTileset-S2_3.patch, #17325
      CategoryNone=>client
      StatusIn Progress=>Ready For Test
      Planned Release=>2.3.5, 2.4.0, 2.5.0
    Sat 23 Feb 2013 08:34:05 AM UTCcazfiStatusNone=>In Progress
      Assigned toNone=>cazfi
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup