bugFreeciv - Bugs: bug #20018, Alternative gfx tag never used for...

 
 
Show feedback again

bug #20018: Alternative gfx tag never used for unit orientation sprites

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Thu 02 Aug 2012 01:53:09 AM UTC  
 
Category: clientSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 04 Aug 2012 10:19:31 PM UTC, SVN revision 21712:

Fixed using of alternative orientation sprites.

See gna bug #20018

(Browse SVN revision 21712)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 04 Aug 2012 10:19:21 PM UTC, SVN revision 21711:

Fixed using of alternative orientation sprites.

See gna bug #20018

(Browse SVN revision 21711)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 02 Aug 2012 01:53:09 AM UTC, original submission:

Unit orientation sprites are loaded from primary tags only. If it fails, icon gfx (single sprite) is loaded with either primary or alternative tag. If that too fails (unit has only alternative orientation sprites), or even if alternative icon loading succeedes, alternative orientation sprites are never loaded.
This mess is caused by attempts to avoid loading orientation sprites with one tag, and icon with another.

Attached fix refactors these functions in a way that loading of orientation sprites and icon gfx from single tag happens in one go. If loading from primary tag fails (neither icon or orientation sprites found), new attempt with alternative tag is made.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16280:  OrientFallback.patch added by cazfi (3kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 04 Aug 2012 10:19:45 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Thu 02 Aug 2012 01:53:09 AM UTCcazfiAttached File-=>Added OrientFallback.patch, #16280
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup