bugFreeciv - Bugs: bug #20049, Ugly two line notify message when...

 
 
Show feedback again

bug #20049: Ugly two line notify message when roads automatically upgraded

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Fri 10 Aug 2012 09:42:42 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.4.0, 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 24 Jan 2013 08:54:00 PM UTC, SVN revision 22202:

Split ugly two-line message when city gains better roads to two
one-line messages.

See gna bug #20049

(Browse SVN revision 22202)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 24 Jan 2013 08:53:51 PM UTC, SVN revision 22201:

Split ugly two-line message when city gains better roads to two
one-line messages.

See gna bug #20049

(Browse SVN revision 22201)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 24 Jan 2013 08:53:14 PM UTC, comment #3:

Not going to reset inspection period timer because of this, but attached is version of the S2_4 patch without the other patch previous version accidentally contained.

(file #17010)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 22 Jan 2013 09:55:38 PM UTC, comment #2:

Attached patches splits these messages to two one-line messages, without indentation of latter line. In case of single city being affected, both messages mention city name instead of referring to "the city".

(file #16993, file #16994)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 22 Jan 2013 09:39:42 PM UTC, comment #1:

> " Workers spontaneously"


gna reformatting... point was that there's a lot of indentation.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri 10 Aug 2012 09:42:42 PM UTC, original submission:

When new road building technology has been researched, or player with new road building tehcnology captures the city, roads are automatically upgradet. In this case server sends notify message with "\n" in it, and latter line starts " Workers spontaneously" That seems quite out-of-place in chatwindow at least.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 24 Jan 2013 08:54:35 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Thu 24 Jan 2013 08:53:14 PM UTCcazfiAttached File-=>Added SpontaneousWorkersMsg-S2_4-2.patch, #17010
    Tue 22 Jan 2013 09:55:38 PM UTCcazfiAttached File-=>Added SpontaneosWorkersMsg.patch, #16993
      Attached File-=>Added SpontaneosWorkersMsg-S2_4.patch, #16994
      StatusNone=>Ready For Test
      Planned Release=>2.4.0, 2.5.0
    Tue 22 Jan 2013 09:39:42 PM UTCcazfiCategoryNone=>general
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup