bugFreeciv - Bugs: bug #20072, Any unit can_unit_do_connect()...

 
 
Show feedback again

bug #20072: Any unit can_unit_do_connect() when start tile has road already

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Thu 16 Aug 2012 09:44:55 PM UTC  
 
Category: clientSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.5.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 01 Dec 2012 10:01:22 AM UTC, SVN revision 22044:

Do not allow "Connect with Road" for units that are not able to
build road at all even if there's already road present in their
current location.

See gna bug #20072

(Browse SVN revision 22044)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun 18 Nov 2012 11:32:45 AM UTC, comment #1:

Fix attempt. While testing this, I found bug #20304. Until that one is fixed, this one should wait - committing this alone would make things only worse.

(file #16780)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 16 Aug 2012 09:44:55 PM UTC, original submission:

Trying to figure out problems with caravans I noticed that the menus have "Connect with Road" sensitive when they are in road tile.
can_unit_do_connect() returns true for all units (even those who could never build any road) if tile already has road. Such unit ordered to connect road will goto as long as there is existing roads to first tile where it should actually build something and aborts there.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16780:  RoadConnectFix.patch added by cazfi (953B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Updated the item)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 01 Dec 2012 11:02:29 AM UTCjtnStatusWont Fix=>Fixed
    Sat 01 Dec 2012 10:01:45 AM UTCcazfiStatusReady For Test=>Wont Fix
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sun 18 Nov 2012 11:32:45 AM UTCcazfiAttached File-=>Added RoadConnectFix.patch, #16780
      CategoryNone=>client
      StatusNone=>Ready For Test
      Planned Release=>2.5.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup