bugFreeciv - Bugs: bug #20097, Use GtkOrientation (migrate from...

 
 
Show feedback again

bug #20097: Use GtkOrientation (migrate from gtk2) and fix GdkModifierType mask handling

Submitted by:  Goran Rakic <grakic>
Submitted on:  Sun 26 Aug 2012 01:16:37 AM UTC  
 
Category: client-gtk-3.0Severity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: 2.4.0-beta1Operating System: None
Planned Release: 2.4.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun 07 Apr 2013 12:21:37 PM UTC, comment #6:

> Do we expect that to have fixed all issues reported in this ticket?


Well, yes and no.

As I repeated in a few bugs here, the way freeciv is using 'row-activated' signal was never was never really correct, so I don't see any proper fix for that - it was always working just cause it wanted to, not cause it had to. Also I'm unable to reproduce the problem anyway.

On a not quite related note: I wonder how much will break in regard of theming with gtk+ 3.8 release (given the number of commits to 3.8 branch, I'm waiting till 3.8.1).

Rafał Mużyło <galtgendo>
Sun 07 Apr 2013 12:34:40 AM UTC, comment #5:

>> Take note of patch #3469, thank you.
> For most patches of patch #3469 has gone in to TRUNK only.

Now they've all been backported to S2_4.
Do we expect that to have fixed all issues reported in this ticket?

Jacob Nevins <jtn>
Project Administrator
Fri 22 Feb 2013 08:51:35 AM UTC, comment #4:

> Take note of patch #3469, thank you.


For most patches of patch #3469 has gone in to TRUNK only. Have the already cherry-picked patches to S2_4 fixed this, or do we still need to backport fix for problem in this ticket?

Marko Lindqvist <cazfi>
Project Administrator
Mon 27 Aug 2012 01:35:49 PM UTC, comment #3:

@comment #2:
That's exactly what I've meant by "I can't reproduce" - this "works" correctly here, even if the code isn't really correct.

Rafał Mużyło <galtgendo>
Sun 26 Aug 2012 11:47:54 PM UTC, comment #2:

I did not know about the Patches section. The patch attached here may be easier and safer to apply, otherwise the bug report may be closed.

I do not understand your comment about the Control key. In the city dialog there is a code to test if the Control is pressed while double clicking on the improvement. If it is, it should open the help dialog and if not it should sell the improvement.

With the old code help dialog opens all the time. When this code is changed to a new device/pointer API the mask behaves correctly and if no Control key is pressed the improvement will be sold.

It may be related to me having two displays on nvidia RandR-enabled device. I do not know the inner working of GTK+.

Goran Rakic <grakic>
Sun 26 Aug 2012 03:17:43 AM UTC, comment #1:

Take note of patch #3469, thank you.
As for that part about Control key, I can't reproduce, but I'm aware of the problem; there's no good solution yet - that signal wasn't meant to be used that way.

Rafał Mużyło <galtgendo>
Sun 26 Aug 2012 01:16:37 AM UTC, original submission:

Testing 2.4.0-beta1 release on Fedora 17 (the latest RandR-enabled nvidia driver with two displays), using the deprecated gdk_window_get_pointer() to get a current GdkModifierType mask does not work.

It is not possible to sell a improvement from the city dialog and help window will open even without holding the Control key. When changed to use new gdk_window_get_device_position() it works.

I also used a regular expression to update all hbox/vbox/... code to use new API passing GtkOrientation argument.

The patch is attached.

Goran Rakic <grakic>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16425:  freeciv-gtk3-deprecated.patch added by grakic (64kB - text/x-patch - Patch against 2.4.0-beta1)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by grakic (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 22 Feb 2013 08:52:18 AM UTCcazfiPlanned Release=>2.4.0
    Sun 26 Aug 2012 01:16:38 AM UTCgrakicAttached File-=>Added freeciv-gtk3-deprecated.patch, #16425
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup